Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(jellyfish-api-core): add amount format option for listAccountHistory RPC #1569

Merged
merged 14 commits into from
Jun 30, 2022

Conversation

chanakasameera
Copy link
Contributor

@chanakasameera chanakasameera commented Jun 16, 2022

What this PR does / why we need it:

Configure the format of amounts returned by listAccountHistory
id - amount with the following 'id' -> @id
symbol - amount with the following 'symbol' -> @symbol
DeFiCh/ain#1330

Which issue(s) does this PR fixes?:

Fixes #

Additional comments?:

@codeclimate
Copy link

codeclimate bot commented Jun 16, 2022

Code Climate has analyzed commit 546f797 and detected 0 issues on this pull request.

View more on Code Climate.

@netlify
Copy link

netlify bot commented Jun 16, 2022

Deploy Preview for jellyfishsdk ready!

Name Link
🔨 Latest commit 546f797
🔍 Latest deploy log https://app.netlify.com/sites/jellyfishsdk/deploys/62bd2ecfac2215000823cb73
😎 Deploy Preview https://deploy-preview-1569--jellyfishsdk.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented Jun 16, 2022

Codecov Report

Merging #1569 (546f797) into main (442676a) will increase coverage by 2.08%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1569      +/-   ##
==========================================
+ Coverage   91.56%   93.65%   +2.08%     
==========================================
  Files         360      360              
  Lines       10346    10349       +3     
  Branches     1285     1286       +1     
==========================================
+ Hits         9473     9692     +219     
+ Misses        823      630     -193     
+ Partials       50       27      -23     
Impacted Files Coverage Δ
...ackages/jellyfish-api-core/src/category/account.ts 100.00% <100.00%> (ø)
apps/legacy-api/src/controllers/MiscController.ts 25.80% <0.00%> (-74.20%) ⬇️
apps/legacy-api/src/modules/LoggingModule.ts 81.81% <0.00%> (-18.19%) ⬇️
packages/jellyfish-api-core/src/category/vault.ts 94.73% <0.00%> (-5.27%) ⬇️
...whale-api/src/module.indexer/rpc.block.provider.ts 89.28% <0.00%> (-4.77%) ⬇️
...s/legacy-api/src/controllers/PoolPairController.ts 85.71% <0.00%> (+1.19%) ⬆️
...pps/whale-api/src/module.api/address.controller.ts 98.05% <0.00%> (+1.94%) ⬆️
packages/jellyfish-api-core/src/category/oracle.ts 94.28% <0.00%> (+2.85%) ⬆️
packages/jellyfish-api-core/src/category/loan.ts 100.00% <0.00%> (+3.27%) ⬆️
...s/testcontainers/src/containers/DockerContainer.ts 98.21% <0.00%> (+3.57%) ⬆️
... and 29 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 442676a...546f797. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Jun 16, 2022

Docker build preview for jellyfish/apps is ready!

Built with commit b821124

  • ghcr.io/jellyfishsdk/legacy-api:pr-1569
  • ghcr.io/jellyfishsdk/ocean-api:pr-1569
  • ghcr.io/jellyfishsdk/playground-api:pr-1569
  • ghcr.io/jellyfishsdk/status-api:pr-1569
  • ghcr.io/jellyfishsdk/whale-api:pr-1569

You can also get an immutable image with the commit hash

  • ghcr.io/jellyfishsdk/legacy-api:b8211243691df12b5d949cea3a23ebd094d6ac40
  • ghcr.io/jellyfishsdk/ocean-api:b8211243691df12b5d949cea3a23ebd094d6ac40
  • ghcr.io/jellyfishsdk/playground-api:b8211243691df12b5d949cea3a23ebd094d6ac40
  • ghcr.io/jellyfishsdk/status-api:b8211243691df12b5d949cea3a23ebd094d6ac40
  • ghcr.io/jellyfishsdk/whale-api:b8211243691df12b5d949cea3a23ebd094d6ac40

@chanakasameera chanakasameera changed the title feat(jellyfish-api-core): add amountFormat option for listAccountHistory RPC feat(jellyfish-api-core): add amount format option for listAccountHistory RPC Jun 27, 2022
@chanakasameera chanakasameera marked this pull request as ready for review June 27, 2022 14:26
canonbrother
canonbrother previously approved these changes Jun 28, 2022
Copy link
Contributor

@surangap surangap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

next fork flag

@surangap
Copy link
Contributor

next fork flag

wait for #1580
it has flags set and fixed all failing tests

@fuxingloh fuxingloh merged commit bb46104 into main Jun 30, 2022
@fuxingloh fuxingloh deleted the chanakasameera/add-tokenid-history-rpcs branch June 30, 2022 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants