-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(jellyfish-api-core): add amount format option for listAccountHistory RPC #1569
Conversation
Code Climate has analyzed commit 546f797 and detected 0 issues on this pull request. View more on Code Climate. |
✅ Deploy Preview for jellyfishsdk ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Codecov Report
@@ Coverage Diff @@
## main #1569 +/- ##
==========================================
+ Coverage 91.56% 93.65% +2.08%
==========================================
Files 360 360
Lines 10346 10349 +3
Branches 1285 1286 +1
==========================================
+ Hits 9473 9692 +219
+ Misses 823 630 -193
+ Partials 50 27 -23
Continue to review full report at Codecov.
|
Docker build preview for jellyfish/apps is ready! Built with commit b821124
You can also get an immutable image with the commit hash
|
packages/jellyfish-api-core/__tests__/category/account/listAccountHistory.test.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
next fork flag
wait for #1580 |
What this PR does / why we need it:
Configure the format of amounts returned by listAccountHistory
id - amount with the following 'id' -> @id
symbol - amount with the following 'symbol' -> @symbol
DeFiCh/ain#1330
Which issue(s) does this PR fixes?:
Fixes #
Additional comments?: