-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(jellyfish-api-core): add token split testing #1475
Conversation
…ests # Conflicts: # packages/testcontainers/src/containers/DeFiDContainer.ts
Should we change |
you are only seeing one use of the tests. but once these tests are written and included in the CI testing, these tests run over each and every future change of defid/jellyfish. Thus make sure the core functionality is intact over the changes. That's why it's important to get the tests right at the first place. |
https://github.com/DeFiCh/ain/blob/27e9965efd4b3b6d4beffefeb08ef902a6a37c49/src/validation.cpp#L4387 |
Apply the same too
In feature_token_split.py, every call of v0/oracles/splits/, they generate 2 blocks. I am unsure is there a problem there |
I assume there is no other more important task |
packages/jellyfish-api-core/__tests__/category/masternode/setGov.locks.token.test.ts
Show resolved
Hide resolved
I guess is 2 blocks right? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is gonna be hard to index on whale-api
due to non-deterministic events especially getting the current txid
to map to PoolPair
. I guess to make things simple we can just remove those values (txid, tokenid, poolpairid).
Otherwise, we could also; might have to - build a DEX indexer away from the main whale-api
to protect it from regression 😿
Related to #1532 regression
What this PR does / why we need it:
Which issue(s) does this PR fixes?:
Fixes #1527 and DeFiCh/ain#1243
Additional comments?: