-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(jellyfish-api-core): Add account withdrawFutureSwap RPC #1323
feat(jellyfish-api-core): Add account withdrawFutureSwap RPC #1323
Conversation
Code Climate has analyzed commit e345d18 and detected 0 issues on this pull request. View more on Code Climate. |
✅ Deploy Preview for jellyfish-defi ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
…h into surangap/dfi2203-futures
Codecov Report
@@ Coverage Diff @@
## main #1323 +/- ##
==========================================
+ Coverage 88.13% 90.21% +2.08%
==========================================
Files 339 348 +9
Lines 9858 10014 +156
Branches 1211 1223 +12
==========================================
+ Hits 8688 9034 +346
+ Misses 1109 930 -179
+ Partials 61 50 -11
Continue to review full report at Codecov.
|
…utures-withdrawfutureswap
Docker build preview for jellyfish/apps is ready! Built with commit 515b8e0
|
…h into surangap/dfi2203-futures
packages/jellyfish-api-core/__tests__/category/account/withdrawFutureSwap.test.ts
Outdated
Show resolved
Hide resolved
packages/jellyfish-api-core/__tests__/category/account/withdrawFutureSwap.test.ts
Show resolved
Hide resolved
What happened if withdrawFutureSwap BTC which is not a loan token? |
What happened if destinationToken is 'ABC'? |
These are covered now |
This is covered now |
packages/jellyfish-api-core/__tests__/category/account/withdrawFutureSwap.test.ts
Outdated
Show resolved
Hide resolved
packages/jellyfish-api-core/__tests__/category/account/withdrawFutureSwap.test.ts
Outdated
Show resolved
Hide resolved
packages/jellyfish-api-core/__tests__/category/account/withdrawFutureSwap.test.ts
Outdated
Show resolved
Hide resolved
packages/jellyfish-api-core/__tests__/category/account/withdrawFutureSwap.test.ts
Outdated
Show resolved
Hide resolved
e345d18
What this PR does / why we need it:
Add account withdrawFutureSwap for dfip2203 futures
Which issue(s) does this PR fixes?:
Fixes #
#1268
Additional comments?: