Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(jellyfish-api-core): Add account withdrawFutureSwap RPC #1323

Merged
merged 44 commits into from
Apr 11, 2022

Conversation

chanakasameera
Copy link
Contributor

What this PR does / why we need it:

Add account withdrawFutureSwap for dfip2203 futures

Which issue(s) does this PR fixes?:

Fixes #
#1268

Additional comments?:

@codeclimate
Copy link

codeclimate bot commented Apr 5, 2022

Code Climate has analyzed commit e345d18 and detected 0 issues on this pull request.

View more on Code Climate.

@netlify
Copy link

netlify bot commented Apr 5, 2022

Deploy Preview for jellyfish-defi ready!

Name Link
🔨 Latest commit e345d18
🔍 Latest deploy log https://app.netlify.com/sites/jellyfish-defi/deploys/6253fd9ef1d74b0008fc9684
😎 Deploy Preview https://deploy-preview-1323--jellyfish-defi.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented Apr 5, 2022

Codecov Report

Merging #1323 (e345d18) into main (34e1724) will increase coverage by 2.08%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1323      +/-   ##
==========================================
+ Coverage   88.13%   90.21%   +2.08%     
==========================================
  Files         339      348       +9     
  Lines        9858    10014     +156     
  Branches     1211     1223      +12     
==========================================
+ Hits         8688     9034     +346     
+ Misses       1109      930     -179     
+ Partials       61       50      -11     
Impacted Files Coverage Δ
...ackages/jellyfish-api-core/src/category/account.ts 92.20% <0.00%> (-3.80%) ⬇️
apps/whale/src/module.api/rpc.controller.ts 50.00% <0.00%> (-25.00%) ⬇️
...ckages/jellyfish-address/src/script/Base58Check.ts 85.00% <0.00%> (-10.00%) ⬇️
packages/jellyfish-api-core/src/category/spv.ts 72.09% <0.00%> (-9.31%) ⬇️
...transaction-builder/src/txn/txn_builder_account.ts 60.00% <0.00%> (-5.72%) ⬇️
...ners/src/containers/RegTestContainer/Masternode.ts 92.03% <0.00%> (-5.31%) ⬇️
packages/jellyfish-address/src/p2pkh.ts 95.23% <0.00%> (-4.77%) ⬇️
packages/jellyfish-address/src/script/P2WSH.ts 95.45% <0.00%> (-4.55%) ⬇️
...ages/jellyfish-api-core/src/category/masternode.ts 95.45% <0.00%> (-4.55%) ⬇️
... and 45 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34e1724...e345d18. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Apr 5, 2022

Docker build preview for jellyfish/apps is ready!

Built with commit 515b8e0

  • ghcr.io/defich/legacy-api:pr-1323
  • ghcr.io/defich/ocean-api:pr-1323
  • ghcr.io/defich/playground-api:pr-1323
  • ghcr.io/defich/status-api:pr-1323

@chanakasameera chanakasameera linked an issue Apr 6, 2022 that may be closed by this pull request
@jingyi2811
Copy link
Contributor

jingyi2811 commented Apr 11, 2022

Screenshot 2022-04-11 at 11 38 55 AM

You can move the test units just after the non-utxo test units.

Test units for single swap should be grouped together

@jingyi2811
Copy link
Contributor

jingyi2811 commented Apr 11, 2022

What happened if withdrawFutureSwap BTC which is not a loan token?
What happened if passed in bcrt1qcnfukr6c78wlz2tqpv8vxe0zu339c06pmm3l30 as the address parameter?

@jingyi2811
Copy link
Contributor

What happened if destinationToken is 'ABC'?

@chanakasameera
Copy link
Contributor Author

Screenshot 2022-04-11 at 11 38 55 AM

You can move the test units just after the non-utxo test units.

Test units for single swap should be grouped together

This is done

@chanakasameera
Copy link
Contributor Author

These are covered now

@chanakasameera
Copy link
Contributor Author

What happened if destinationToken is 'ABC'?

This is covered now

jingyi2811
jingyi2811 previously approved these changes Apr 11, 2022
surangap
surangap previously approved these changes Apr 11, 2022
@surangap surangap requested a review from jingyi2811 April 11, 2022 09:22
jingyi2811
jingyi2811 previously approved these changes Apr 11, 2022
@chanakasameera chanakasameera dismissed stale reviews from jingyi2811 and surangap via e345d18 April 11, 2022 10:06
@fuxingloh fuxingloh merged commit d7819a5 into main Apr 11, 2022
@fuxingloh fuxingloh deleted the chanakasameera/dfi2203-futures-withdrawfutureswap branch April 11, 2022 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

packages/jellyfish-api-core: Add DFI2203 Futures work
7 participants