rawtx.createRawTransaction, rawtx.signRawTransactionWithKey, rawtx.testMempoolAccept, rawtx.sendRawTransaction #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for jellyfish-defi ready! Built with commit cee5030 |
size-limit report 📦
|
fuxingloh
force-pushed
the
fuxingloh/jellyfish-api-core-rawtx
branch
from
9d65a6b to
33191ce
Compare
Codecov Report
@@ Coverage Diff @@
## main #127 +/- ##
==========================================
+ Coverage 94.32% 94.38% +0.06%
==========================================
Files 36 37 +1
Lines 793 784 -9
Branches 92 93 +1
==========================================
- Hits 748 740 -8
Misses 42 42
+ Partials 3 2 -1
Continue to review full report at Codecov.
|
fuxingloh
requested review from
canonbrother,
fullstackninja864 and
thedoublejay
as code owners
testMempoolAccept createRawTransaction signRawTransactionWithKey
fuxingloh
force-pushed
the
fuxingloh/jellyfish-api-core-rawtx
branch
from
33191ce to
a66fcf6
Compare
fuxingloh
force-pushed
the
fuxingloh/jellyfish-api-core-rawtx
branch
from
b3526df to
b88cbe9
Compare
Comment on lines
62
to
67
| const { sigHashType = SigHashType.ALL } = options | ||
| return await this.client.call('signrawtransactionwithkey', [ | ||
| rawTx, privKeys, options.prevTxs, sigHashType | ||
| ], 'number') | ||
| } | ||
|
|
There was a problem hiding this comment.
ahh.. one more..
const { privKeys = [], sigHashType = SigHashType.ALL } = options
return await this.client.call('signrawtransactionwithkey', [
rawTx, privKeys, prevTxs, sigHashType
], 'number')
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
canonbrother
approved these changes
Apr 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of PR is this?:
/kind feature
What this PR does / why we need it:
Added types for
rawtx.ts#48I added
//TODOcomments for some parts of the code as it's beyond my scope to implement them. Need to work on others features now.