Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

poolpair.listpoolpairs, poolpair.getpoolpair, poolpair.listpoolshares, poolpair.createpoolpair, poolpair.addpoolliquidity #121

Conversation

canonbrother
Copy link
Contributor

@canonbrother canonbrother commented Apr 14, 2021

What kind of PR is this?:

/kind feature

What this PR does / why we need it:

Implemented type for RPC: #48

  1. poolpair.listPoolPairs
  2. poolpair.getPoolPair
  3. poolpair.listPoolShares
  4. poolpair.createPoolPair
  5. poolpair.addpoolliquidity

@netlify
Copy link

netlify bot commented Apr 14, 2021

Deploy preview for jellyfish-defi ready!

Built with commit d4e0fd2

https://deploy-preview-121--jellyfish-defi.netlify.app

@defichain-bot defichain-bot added the kind/feature New feature request label Apr 14, 2021
@github-actions
Copy link

github-actions bot commented Apr 14, 2021

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
packages/jellyfish/dist/jellyfish.umd.js 18.42 KB (+1.27% 🔺) 369 ms (+1.27% 🔺) 159 ms (-4.59% 🔽) 528 ms

@codecov
Copy link

codecov bot commented Apr 15, 2021

Codecov Report

Merging #121 (d4e0fd2) into main (5d8e2e4) will increase coverage by 0.13%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #121      +/-   ##
==========================================
+ Coverage   95.34%   95.47%   +0.13%     
==========================================
  Files          50       52       +2     
  Lines        1074     1105      +31     
  Branches      130      137       +7     
==========================================
+ Hits         1024     1055      +31     
  Misses         48       48              
  Partials        2        2              
Impacted Files Coverage Δ
packages/jellyfish-api-core/src/category/rawtx.ts 100.00% <ø> (ø)
packages/jellyfish-api-core/src/category/token.ts 100.00% <ø> (ø)
packages/jellyfish-api-core/src/category/wallet.ts 100.00% <ø> (ø)
...jellyfish-transaction/src/buffer/buffer_varuint.ts 100.00% <ø> (ø)
...ckages/jellyfish-api-core/src/category/poolpair.ts 100.00% <100.00%> (ø)
packages/jellyfish-api-core/src/index.ts 100.00% <100.00%> (ø)
...llyfish-transaction/src/buffer/buffer_bignumber.ts 100.00% <100.00%> (ø)
...ellyfish-transaction/src/buffer/buffer_composer.ts 98.57% <100.00%> (-0.06%) ⬇️
packages/jellyfish-transaction/src/tx_signature.ts 95.83% <100.00%> (+0.05%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d15e0a...d4e0fd2. Read the comment docs.

@fuxingloh fuxingloh added this to the Jellyfish Documentation milestone Apr 15, 2021
@canonbrother canonbrother changed the title poolpair.listpoolpairs, poolpair.getpoolpair, poolpair.listpoolshares poolpair.listpoolpairs, poolpair.getpoolpair, poolpair.listpoolshares, poolpair.createpoolpair Apr 19, 2021
@canonbrother canonbrother changed the title poolpair.listpoolpairs, poolpair.getpoolpair, poolpair.listpoolshares, poolpair.createpoolpair poolpair.listpoolpairs, poolpair.getpoolpair, poolpair.listpoolshares, poolpair.createpoolpair, poolpair.addpoolliquidity Apr 23, 2021
@canonbrother canonbrother marked this pull request as ready for review April 23, 2021 12:03
@canonbrother canonbrother requested a review from fuxingloh as a code owner April 23, 2021 12:03
@fuxingloh fuxingloh merged commit 9ae8aa4 into main Apr 26, 2021
@fuxingloh fuxingloh deleted the canonbrother/rpc-poolpair-listpoolpairs-getpoolpair-listpoolshares branch April 26, 2021 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants