-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(jellyfish-api-core): add hex
field in AccountOwner interface
#1083
Conversation
Code Climate has analyzed commit 88cc1d8 and detected 0 issues on this pull request. View more on Code Climate. |
Codecov Report
@@ Coverage Diff @@
## main #1083 +/- ##
==========================================
- Coverage 95.54% 95.21% -0.33%
==========================================
Files 168 169 +1
Lines 5007 5039 +32
Branches 654 657 +3
==========================================
+ Hits 4784 4798 +14
- Misses 215 230 +15
- Partials 8 11 +3
Continue to review full report at Codecov.
|
✔️ Deploy Preview for jellyfish-defi ready! 🔨 Explore the source changes: 88cc1d8 🔍 Inspect the deploy log: https://app.netlify.com/sites/jellyfish-defi/deploys/621485affdb3a3000730b7ec 😎 Browse the preview: https://deploy-preview-1083--jellyfish-defi.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
update the tests also
What this PR does / why we need it:
As stated in the issue given, the account owner is missing the
hex
field. This PR adds it as a non-optional field.Which issue(s) does this PR fixes?:
Fixes #1075