Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(jellyfish-api-core): add hex field in AccountOwner interface #1083

Merged
merged 5 commits into from
Feb 23, 2022

Conversation

cwkang1998
Copy link
Contributor

@cwkang1998 cwkang1998 commented Feb 21, 2022

What this PR does / why we need it:

As stated in the issue given, the account owner is missing the hex field. This PR adds it as a non-optional field.

Which issue(s) does this PR fixes?:

Fixes #1075

@codeclimate
Copy link

codeclimate bot commented Feb 21, 2022

Code Climate has analyzed commit 88cc1d8 and detected 0 issues on this pull request.

View more on Code Climate.

@codecov
Copy link

codecov bot commented Feb 21, 2022

Codecov Report

Merging #1083 (88cc1d8) into main (e2d0002) will decrease coverage by 0.32%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1083      +/-   ##
==========================================
- Coverage   95.54%   95.21%   -0.33%     
==========================================
  Files         168      169       +1     
  Lines        5007     5039      +32     
  Branches      654      657       +3     
==========================================
+ Hits         4784     4798      +14     
- Misses        215      230      +15     
- Partials        8       11       +3     
Impacted Files Coverage Δ
...ackages/jellyfish-api-core/src/category/account.ts 100.00% <ø> (ø)
...ish-transaction-builder/src/txn/txn_builder_dex.ts 71.42% <0.00%> (-28.58%) ⬇️
...action-builder/src/txn/txn_builder_icxorderbook.ts 71.42% <0.00%> (-28.58%) ⬇️
...jellyfish-transaction/src/script/dftx/dftx_pool.ts 77.50% <0.00%> (-22.50%) ⬇️
...ontainers/src/containers/RegTestContainer/index.ts 87.50% <0.00%> (-12.50%) ⬇️
packages/jellyfish-api-core/src/category/spv.ts 76.74% <0.00%> (-9.31%) ⬇️
packages/jellyfish-api-core/src/category/oracle.ts 90.90% <0.00%> (-9.10%) ⬇️
packages/jellyfish-api-core/src/category/loan.ts 93.93% <0.00%> (-6.07%) ⬇️
...h-transaction-builder/src/txn/txn_builder_loans.ts 84.84% <0.00%> (-3.04%) ⬇️
...ages/jellyfish-transaction/src/script/dftx/dftx.ts 96.96% <0.00%> (-1.52%) ⬇️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2d0002...88cc1d8. Read the comment docs.

@netlify
Copy link

netlify bot commented Feb 21, 2022

✔️ Deploy Preview for jellyfish-defi ready!

🔨 Explore the source changes: 88cc1d8

🔍 Inspect the deploy log: https://app.netlify.com/sites/jellyfish-defi/deploys/621485affdb3a3000730b7ec

😎 Browse the preview: https://deploy-preview-1083--jellyfish-defi.netlify.app

Copy link
Contributor

@surangap surangap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update the tests also

@fuxingloh fuxingloh merged commit 48d31e0 into main Feb 23, 2022
@fuxingloh fuxingloh deleted the fix-account-owner-interface branch February 23, 2022 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

packages/jellyfish-api-core: map hex field in AccountOwner interface.
6 participants