feat(jellyfish-api-core): add blockchain getChainTxStats RPC #1051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eli-lim
requested review from
fuxingloh,
surangap,
canonbrother,
ivan-zynesis,
jingyi2811 and
chee-chyuan
as code owners
|
Code Climate has analyzed commit bd21937 and detected 1 issue on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
Codecov Report
@@ Coverage Diff @@
## main #1051 +/- ##
==========================================
+ Coverage 93.20% 96.02% +2.82%
==========================================
Files 161 168 +7
Lines 4913 5009 +96
Branches 647 654 +7
==========================================
+ Hits 4579 4810 +231
+ Misses 314 192 -122
+ Partials 20 7 -13
Continue to review full report at Codecov.
|
eli-lim
force-pushed
the
rpc-getchaintxstats
branch
from
d676195 to
721fe09
Compare
chee-chyuan
reviewed
Feb 14, 2022
chee-chyuan
reviewed
Feb 14, 2022
packages/jellyfish-api-core/__tests__/category/blockchain/getChainTxStats.test.ts
Outdated
Show resolved
Hide resolved
chee-chyuan
reviewed
Feb 14, 2022
packages/jellyfish-api-core/__tests__/category/blockchain/getChainTxStats.test.ts
Outdated
Show resolved
Hide resolved
chee-chyuan
reviewed
Feb 14, 2022
packages/jellyfish-api-core/__tests__/category/blockchain/getChainTxStats.test.ts
Outdated
Show resolved
Hide resolved
|
we can include another negative test for when the blockNumber exceeds the blockNumber of the blockHash and we try to |
- remove redundant type checking - change to test window_final_block_hash against block hash
canonbrother
approved these changes
Feb 16, 2022
fuxingloh
reviewed
Feb 23, 2022
Comment on lines
+20
to
+26
| expect(stats.txcount).toStrictEqual(12) | ||
| expect(stats.window_final_block_hash).toStrictEqual(blockHash) | ||
| expect(stats.window_final_block_height).toStrictEqual(3) | ||
| expect(stats.window_block_count).toStrictEqual(2) | ||
| expect(stats.window_tx_count).toStrictEqual(2) | ||
| expect(stats.window_interval).toStrictEqual(2) | ||
| expect(stats.txrate).toStrictEqual(1) |
There was a problem hiding this comment.
expect(stats).toStrictEqual({
txcount: 12,
...
})btw this works too and might be cleaner
fuxingloh
approved these changes
Feb 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
/kind feature
Which issue(s) does this PR fixes?:
Implemented type for RPC: #48