Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support CustomTxType::UpdateMasternode on Jellyfish #1842

Closed
fuxingloh opened this issue Oct 25, 2022 · 5 comments
Closed

Support CustomTxType::UpdateMasternode on Jellyfish #1842

fuxingloh opened this issue Oct 25, 2022 · 5 comments
Assignees
@imkven @infinia-yzl @marktanrj
Labels
apps/whale-api area/apps area/packages kind/feature New feature request priority/urgent-now Urgent fix, as fast as possible triage/accepted Triage has been accepted

Comments

@fuxingloh
Copy link
Contributor

fuxingloh commented Oct 25, 2022 •
edited by marktanrj
Loading

What would you like to be added:

Support DeFiCh/ain#1437

Add CustomTxType::UpdateMasternode DfTx support. This includes:
@fuxingloh fuxingloh added the kind/feature New feature request label Oct 25, 2022
@github-actions
Copy link

@fuxingloh: Thanks for opening an issue, it is currently awaiting triage.

The triage/accepted label can be added by foundation members by writing /triage accepted in a comment.

Details

I am a bot created to help the JellyfishSDK developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@github-actions github-actions bot added needs/triage Waiting for triage to be accepted needs/area Needs area label(s) labels Oct 25, 2022
@github-actions
Copy link

@fuxingloh: There are no 'area' labels on this issue. Adding an appropriate label will greatly expedite the process for us. You can add as many area as you see fit. If you are unsure what to do you can ignore this!

You can add area labels by leaving a /area comment.

Details

I am a bot created to help the JellyfishSDK developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@fuxingloh
Copy link
Contributor Author

/priority important-soon
/area packages apps
/apps whale-api
/triage accepted

@github-actions github-actions bot added triage/accepted Triage has been accepted area/apps area/packages apps/whale-api priority/important-soon Will be important soon and removed needs/triage Waiting for triage to be accepted needs/area Needs area label(s) labels Oct 25, 2022
@fuxingloh
Copy link
Contributor Author

/assign @marktanrj

@fuxingloh
Copy link
Contributor Author

You might want to tackle with multiple PRs, instead of implementing them all at once.

@marktanrj marktanrj mentioned this issue Nov 1, 2022
Merged
@fuxingloh fuxingloh added priority/urgent-now Urgent fix, as fast as possible and removed priority/important-soon Will be important soon labels Nov 14, 2022
@infinia-yzl infinia-yzl assigned helloscoopa and imkven and unassigned helloscoopa Nov 14, 2022
@marktanrj marktanrj mentioned this issue Nov 18, 2022
Merged
This was referenced Nov 22, 2022
Closed
Merged
fuxingloh pushed a commit that referenced this issue Nov 29, 2022
@marktanrj @shohamc1
@helloscoopa @imkven
feat(jellyfish-api-core): Add updatemasternode RPC typings (#1847)
68d604a 
<!--  Thanks for sending a pull request! -->

#### What this PR does / why we need it:

- Add RPC updatemasternode

#### Which issue(s) does this PR fixes?:
<!--
(Optional) Automatically closes linked issue when PR is merged.
Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
-->
Fixes part of #1842

Signed-off-by: Mark Tan <[email protected]>
Co-authored-by: Shoham Chakraborty <[email protected]>
Co-authored-by: Dilshan Madushanka <[email protected]>
Co-authored-by: Kven Ho <[email protected]>
@marktanrj marktanrj mentioned this issue Dec 1, 2022
Merged
fuxingloh pushed a commit that referenced this issue Dec 1, 2022
@marktanrj @imkven
feat(jellyfish-transaction): Add updatemasternode dftx (#1863)
9b418aa 
<!--  Thanks for sending a pull request! -->

#### What this PR does / why we need it:

- updatemasternode DfTx parsing

#### Which issue(s) does this PR fixes?:
<!--
(Optional) Automatically closes linked issue when PR is merged.
Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
-->
Fixes part of #1842

Co-authored-by: Kven Ho <[email protected]>
@fuxingloh fuxingloh mentioned this issue Dec 12, 2022
Closed
fuxingloh added a commit that referenced this issue Dec 12, 2022
@marktanrj @shohamc1
@helloscoopa @infinia-yzl @fuxingloh
feat(apps/whale-api): add updatemasternode indexer (#1869)
97aeb47 
#### What this PR does / why we need it:

Add `UpdateMasternodeIndexer extends DfTxIndexer<UpdateMasternode>` to
update the masternode index when the DfTx UpdaterMasternode transaction
is created.

#### Which issue(s) does this PR fixes?:

Fixes part of #1842

Signed-off-by: Isaac Yong <[email protected]>
Signed-off-by: Kven Ho <[email protected]>
Signed-off-by: Fuxing Loh <[email protected]>
Co-authored-by: Mark Tan <[email protected]>
Co-authored-by: Mark Tan <[email protected]>
Co-authored-by: Shoham Chakraborty <[email protected]>
Co-authored-by: Dilshan Madushanka <[email protected]>
Co-authored-by: Isaac Yong <[email protected]>
Co-authored-by: Fuxing Loh <[email protected]>
fuxingloh pushed a commit that referenced this issue Jan 14, 2023
@marktanrj @infinia-yzl
feat(jellyfish-transaction-builder): Add updatemasternode transaction…
0dc5628 
… builder (#1894)

<!--  Thanks for sending a pull request! -->

#### What this PR does / why we need it:
- updatemasternode transaction builder

#### Which issue(s) does this PR fixes?:
<!--
(Optional) Automatically closes linked issue when PR is merged.
Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
-->
Fixes part of #1842

#### Additional comments?:
- #1863 needed for typings
- <del> #1892 needed for createDeFiTx </del>

Co-authored-by: Isaac Yong <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@imkven imkven

@infinia-yzl infinia-yzl

@marktanrj marktanrj

Labels
apps/whale-api area/apps area/packages kind/feature New feature request priority/urgent-now Urgent fix, as fast as possible triage/accepted Triage has been accepted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@imkven @infinia-yzl @fuxingloh @helloscoopa @marktanrj