-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
testpoolswap
- add auto
and true
arguments to display optimal path and prices for composite swap
#1065
Comments
@thedoublejay: Thanks for opening an issue, it is currently awaiting triage. The triage/accepted label can be added by foundation members by writing /triage accepted in a comment. DetailsI am a bot created to help the DeFiCh developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the DeFiCh/oss-governance-bot repository. |
@thedoublejay: There are no 'area' labels on this issue. Adding an appropriate label will greatly expedite the process for us. You can add as many area as you see fit. If you are unsure what to do you can ignore this! You can add area labels by leaving a DetailsI am a bot created to help the DeFiCh developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the DeFiCh/oss-governance-bot repository. |
/triage accepted Similar to #48 but expanding on top of the existing |
Linked - DeFiCh/ain#1114 Do we want to present the "optimal path" - whether it's a direct or composite swap? |
@thedoublejay To reduce computation load on defichain, shall we expose this optimal path finding as an endpoint on Whale instead? |
@eli-lim Yup! Let's go with optimal path. |
@eli-lim Ok understand your point now. We can move this calculation on Whale side. |
What would you like to be added:
We would like to add
auto
andtrue
arguments fortestpoolswap
so we can use get the optimal path and prices for a swap.Why is this needed:
Currently, the path finding algorithm is done on the client side (both path and prices) and it's causing some noticeable performance issues. Note, address can be from anyone (not validated if you are the owner).
The text was updated successfully, but these errors were encountered: