Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DeFiCh/ain - listaccounthistory should support next with {blockheight,txn-no} #1036

Closed
fuxingloh opened this issue Feb 7, 2022 · 0 comments · Fixed by #1072
Closed

DeFiCh/ain - listaccounthistory should support next with {blockheight,txn-no} #1036

fuxingloh opened this issue Feb 7, 2022 · 0 comments · Fixed by #1072
Assignees
Labels
area/packages kind/feature New feature request priority/important-soon Will be important soon triage/accepted Triage has been accepted

Comments

@fuxingloh
Copy link
Contributor

What would you like to be added:

Currently listaccounthistory on DeFiCh/ain. There isn't a way to effectively pagination as you can't provide txn-no as a pagination token. To support slice pagination; we need to be able to provide to all params within the AccountHistoryKey. Address & BlockHeight is currently supported but, txn-no isn't.

Expected feature: listaccounthistory address {next:{blockheight: ..., txn: ...}}

For reference, this is the key.

struct AccountHistoryKey {
    CScript owner;
    uint32_t blockHeight;
    uint32_t txn; // for order in block

To be implemented on https://github.com/DeFiCh/ain first before we implement it here.

/triage accepted
/priority important-soon
/area packages

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/packages kind/feature New feature request priority/important-soon Will be important soon triage/accepted Triage has been accepted
Projects
None yet
4 participants