Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add txn-no as a pagination token into listaccounthistory rpc #1110

Merged
merged 12 commits into from
Mar 18, 2022
Merged

Add txn-no as a pagination token into listaccounthistory rpc #1110

merged 12 commits into from
Mar 18, 2022

Conversation

chanakasameera
Copy link
Contributor

What kind of PR is this?:

/kind feature

What this PR does / why we need it:

Currently listaccounthistory on DeFiCh/ain. There isn't a way to effectively pagination as you can't provide txn-no as a pagination token. To support slice pagination; we need to be able to provide to all params within the AccountHistoryKey. Address & BlockHeight is currently supported but, txn-no isn't.

Which issue(s) does this PR fixes?:

BirthdayResearch/jellyfishsdk#1036

Fixes #

Additional comments?:

bvbfan
bvbfan suggested changes Feb 16, 2022
View reviewed changes
src/masternodes/rpc_accounts.cpp Outdated Show resolved Hide resolved
bvbfan
bvbfan previously approved these changes Feb 17, 2022
View reviewed changes
@bvbfan bvbfan marked this pull request as ready for review February 17, 2022 06:54
@ivan-zynesis ivan-zynesis mentioned this pull request Feb 18, 2022
Merged
bvbfan
bvbfan previously approved these changes Feb 21, 2022
View reviewed changes
@bvbfan bvbfan self-requested a review February 25, 2022 13:58
bvbfan
bvbfan previously approved these changes Feb 25, 2022
View reviewed changes
surangap
surangap approved these changes Feb 28, 2022
View reviewed changes
Copy link
Contributor

@surangap surangap left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

txn is an input parameter added in this PR. So there can't be an already existing use-case that uses txn input parameter at Cake side. If they also do not depend on txn value in the response, then should be good to go.

@surangap surangap requested a review from bvbfan February 28, 2022 08:07
@prasannavl prasannavl merged commit 2471a96 into master Mar 18, 2022
@prasannavl prasannavl deleted the feature/listaccounthistory_with_txn branch March 18, 2022 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@surangap surangap surangap approved these changes

@fuxingloh fuxingloh Awaiting requested review from fuxingloh

@Mixa84 Mixa84 Awaiting requested review from Mixa84

@uzyn uzyn Awaiting requested review from uzyn

@Bushstar Bushstar Awaiting requested review from Bushstar

@monstrobishi monstrobishi Awaiting requested review from monstrobishi

@bvbfan bvbfan Awaiting requested review from bvbfan

Assignees

@chanakasameera chanakasameera

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@chanakasameera @bvbfan @surangap @prasannavl @defichain-bot