Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add background color to SectionLabel #503

Merged
merged 2 commits into from
Aug 9, 2021
Merged

Conversation

kyleleow
Copy link
Contributor

@kyleleow kyleleow commented Aug 9, 2021

What kind of PR is this?:

/kind feature

What this PR does / why we need it:

  • To improve UI when scrolling in Dex screen

Which issue(s) does this PR fixes?:

Fixes #497

Additional comments?:

Not tested on Android device

@kyleleow kyleleow self-assigned this Aug 9, 2021
@defichain-bot defichain-bot added area/ui-ux kind/feature New feature request labels Aug 9, 2021
@codeclimate
Copy link

codeclimate bot commented Aug 9, 2021

Code Climate has analyzed commit 3c96740 and detected 0 issues on this pull request.

View more on Code Climate.

@codecov
Copy link

codecov bot commented Aug 9, 2021

Codecov Report

Merging #503 (3c96740) into main (73fa3a1) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #503   +/-   ##
=======================================
  Coverage   87.18%   87.18%           
=======================================
  Files         113      113           
  Lines        1904     1904           
  Branches      304      305    +1     
=======================================
  Hits         1660     1660           
  Misses        244      244           
Impacted Files Coverage Δ
app/components/SectionTitle.tsx 100.00% <ø> (ø)
app/components/HeaderTitle.tsx 85.18% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73fa3a1...3c96740. Read the comment docs.

@netlify
Copy link

netlify bot commented Aug 9, 2021

✔️ Deploy Preview for defi-wallet ready!

🔨 Explore the source changes: 3c96740

🔍 Inspect the deploy log: https://app.netlify.com/sites/defi-wallet/deploys/6110c90a188f0b0007db04be

😎 Browse the preview: https://deploy-preview-503--defi-wallet.netlify.app/

@defichain-bot
Copy link
Contributor

Build preview for DeFi Wallet is ready!

Built with commit d02fad2

https://expo.io/@defichain/wallet?release-channel=pr-preview-503

@cypress
Copy link

cypress bot commented Aug 9, 2021



Test summary

132 0 0 0


Run details

Project wallet
Status Passed
Commit d02fad2 ℹ️
Started Aug 9, 2021 6:23 AM
Ended Aug 9, 2021 6:45 AM
Duration 22:09 💡
OS Linux Ubuntu - 20.04
Browser Chrome 92

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@thedoublejay thedoublejay marked this pull request as ready for review August 9, 2021 06:48
@thedoublejay thedoublejay merged commit 16d1ebd into main Aug 9, 2021
@thedoublejay thedoublejay deleted the kengye/add-sectionlabel-bg branch August 9, 2021 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui-ux kind/feature New feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SectionLabel should have background color
3 participants