Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e - improve tests #461

Merged
merged 5 commits into from
Aug 7, 2021
Merged

e2e - improve tests #461

merged 5 commits into from
Aug 7, 2021

Conversation

thedoublejay
Copy link
Member

What kind of PR is this?:

/kind refactor

What this PR does / why we need it:

  1. Improved overall e2e tests
  2. Updated structure for Onboarding and with Wallet context
  3. Updated naming to more english like sentences, so we can use it as reference for Manual Testing
  4. Remove LoadingNavigator as Loading will be loaded as a component
  5. Added missing tests and improved overall test coverage

Which issue(s) does this PR fixes?:

Fixes #

Additional comments?:

@codeclimate
Copy link

codeclimate bot commented Aug 7, 2021

Code Climate has analyzed commit 8981289 and detected 0 issues on this pull request.

View more on Code Climate.

@codecov
Copy link

codecov bot commented Aug 7, 2021

Codecov Report

Merging #461 (8981289) into main (eba1880) will increase coverage by 62.72%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##             main     #461       +/-   ##
===========================================
+ Coverage   23.99%   86.72%   +62.72%     
===========================================
  Files         104      111        +7     
  Lines        1771     1861       +90     
  Branches      292      299        +7     
===========================================
+ Hits          425     1614     +1189     
+ Misses       1344      246     -1098     
+ Partials        2        1        -1     
Impacted Files Coverage Δ
app/components/LoadingScreen.tsx 100.00% <ø> (ø)
...ns/AppNavigator/screens/Balances/ConvertScreen.tsx 97.18% <ø> (+97.18%) ⬆️
...reens/AppNavigator/screens/Dex/DexAddLiquidity.tsx 98.48% <ø> (+98.48%) ⬆️
...pNavigator/screens/Dex/PoolSwap/PoolSwapScreen.tsx 95.74% <ø> (+95.74%) ⬆️
app/screens/TransactionAuthorization.tsx 86.04% <ø> (+84.49%) ⬆️
...Navigator/screens/CreateWallet/EnrollBiometric.tsx 0.00% <ø> (ø)
...ator/screens/CreateWallet/VerifyMnemonicWallet.tsx 85.71% <ø> (+83.67%) ⬆️
...or/screens/RestoreWallet/RestoreMnemonicWallet.tsx 100.00% <ø> (+100.00%) ⬆️
...avigator/screens/components/OnboardingCarousel.tsx 100.00% <ø> (+84.61%) ⬆️
app/store/block.ts 100.00% <ø> (+100.00%) ⬆️
... and 65 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eba1880...8981289. Read the comment docs.

@netlify
Copy link

netlify bot commented Aug 7, 2021

✔️ Deploy Preview for defi-wallet ready!

🔨 Explore the source changes: 8981289

🔍 Inspect the deploy log: https://app.netlify.com/sites/defi-wallet/deploys/610e01fc7a14320007ca1d70

😎 Browse the preview: https://deploy-preview-461--defi-wallet.netlify.app

@defichain-bot
Copy link
Contributor

defichain-bot commented Aug 7, 2021

Build preview for DeFi Wallet is ready!

Built with commit 4294354

https://expo.io/@defichain/wallet?release-channel=pr-preview-461

@cypress
Copy link

cypress bot commented Aug 7, 2021



Test summary

165 0 0 0


Run details

Project wallet
Status Passed
Commit 4294354 ℹ️
Started Aug 7, 2021 3:49 AM
Ended Aug 7, 2021 4:06 AM
Duration 17:02 💡
OS Linux Ubuntu - 20.04
Browser Chrome 92

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@fuxingloh fuxingloh merged commit 6991747 into main Aug 7, 2021
@fuxingloh fuxingloh deleted the thedoublejay/cypress_reorg branch August 7, 2021 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants