Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrypt Difficulty - reduce encrypt/decrypt time #456

Merged
merged 6 commits into from
Aug 6, 2021

Conversation

ivan-zynesis
Copy link
Contributor

@ivan-zynesis ivan-zynesis commented Aug 6, 2021

What kind of PR is this?:

/kind feature

What this PR does / why we need it:

Reduce encrypt/decrypt difficulty for reasonable UX

Which issue(s) does this PR fixes?:

Fixes #422

Additional comments?:

@codeclimate
Copy link

codeclimate bot commented Aug 6, 2021

Code Climate has analyzed commit 21cf75f and detected 0 issues on this pull request.

View more on Code Climate.

@defichain-bot defichain-bot added the kind/feature New feature request label Aug 6, 2021
@codecov
Copy link

codecov bot commented Aug 6, 2021

Codecov Report

Merging #456 (21cf75f) into main (f54fff6) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #456   +/-   ##
=======================================
  Coverage   87.86%   87.87%           
=======================================
  Files         103      103           
  Lines        1673     1674    +1     
  Branches      268      268           
=======================================
+ Hits         1470     1471    +1     
  Misses        202      202           
  Partials        1        1           
Impacted Files Coverage Δ
app/api/wallet/provider/mnemonic_encrypted.ts 93.33% <100.00%> (+0.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f54fff6...21cf75f. Read the comment docs.

@netlify
Copy link

netlify bot commented Aug 6, 2021

✔️ Deploy Preview for defi-wallet ready!

🔨 Explore the source changes: 21cf75f

🔍 Inspect the deploy log: https://app.netlify.com/sites/defi-wallet/deploys/610d09891608d10008bcfe79

😎 Browse the preview: https://deploy-preview-456--defi-wallet.netlify.app/

@defichain-bot
Copy link
Contributor

defichain-bot commented Aug 6, 2021

Build preview for DeFi Wallet is ready!

Built with commit 8d2eec3

https://expo.io/@defichain/wallet?release-channel=pr-preview-456

@cypress
Copy link

cypress bot commented Aug 6, 2021



Test summary

127 0 0 0


Run details

Project wallet
Status Passed
Commit 8d2eec3 ℹ️
Started Aug 6, 2021 10:09 AM
Ended Aug 6, 2021 10:22 AM
Duration 13:16 💡
OS Linux Ubuntu - 20.04
Browser Chrome 92

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@thedoublejay thedoublejay requested a review from fuxingloh August 6, 2021 10:06
@thedoublejay thedoublejay enabled auto-merge (squash) August 6, 2021 10:06
@thedoublejay thedoublejay merged commit 1247387 into main Aug 6, 2021
@thedoublejay thedoublejay deleted the ivan/reduce-scrypt-difficulty-time branch August 6, 2021 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/api kind/feature New feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

scrypt - lower difficulty
4 participants