Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restore - type assist #452

Merged
merged 1 commit into from
Aug 6, 2021
Merged

restore - type assist #452

merged 1 commit into from
Aug 6, 2021

Conversation

kyleleow
Copy link
Contributor

@kyleleow kyleleow commented Aug 6, 2021

What kind of PR is this?:

/kind fix

What this PR does / why we need it:

  • Enable dictionary type assist when typing in restore wallet screen

Which issue(s) does this PR fixes?:

Fixes #446

@codeclimate
Copy link

codeclimate bot commented Aug 6, 2021

Code Climate has analyzed commit 38f87e0 and detected 0 issues on this pull request.

View more on Code Climate.

@codecov
Copy link

codecov bot commented Aug 6, 2021

Codecov Report

Merging #452 (38f87e0) into main (4b01680) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #452   +/-   ##
=======================================
  Coverage   87.86%   87.86%           
=======================================
  Files         103      103           
  Lines        1673     1673           
  Branches      268      268           
=======================================
  Hits         1470     1470           
  Misses        202      202           
  Partials        1        1           
Impacted Files Coverage Δ
...or/screens/RestoreWallet/RestoreMnemonicWallet.tsx 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b01680...38f87e0. Read the comment docs.

@netlify
Copy link

netlify bot commented Aug 6, 2021

✔️ Deploy Preview for defi-wallet ready!

🔨 Explore the source changes: 38f87e0

🔍 Inspect the deploy log: https://app.netlify.com/sites/defi-wallet/deploys/610cdcbbcc28a300080ebe05

😎 Browse the preview: https://deploy-preview-452--defi-wallet.netlify.app/

@defichain-bot
Copy link
Contributor

Build preview for DeFi Wallet is ready!

Built with commit bed8d17

https://expo.io/@defichain/wallet?release-channel=pr-preview-452

@cypress
Copy link

cypress bot commented Aug 6, 2021



Test summary

127 0 0 0


Run details

Project wallet
Status Passed
Commit bed8d17 ℹ️
Started Aug 6, 2021 6:57 AM
Ended Aug 6, 2021 7:10 AM
Duration 13:00 💡
OS Linux Ubuntu - 20.04
Browser Chrome 92

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@kyleleow kyleleow marked this pull request as ready for review August 6, 2021 07:58
@thedoublejay thedoublejay merged commit 2590bd5 into main Aug 6, 2021
@thedoublejay thedoublejay deleted the kengye/restore-type-assist branch August 6, 2021 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

restore - type assist
3 participants