Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transactions - display medianTime for transactions #419

Merged
merged 5 commits into from
Aug 5, 2021

Conversation

kyleleow
Copy link
Contributor

@kyleleow kyleleow commented Aug 4, 2021

What kind of PR is this?:

/kind feature

Which issue(s) does this PR fixes?:

Fixes #402

@kyleleow kyleleow self-assigned this Aug 4, 2021
@defichain-bot defichain-bot added kind/feature New feature request area/ui-ux labels Aug 4, 2021
@codeclimate
Copy link

codeclimate bot commented Aug 4, 2021

Code Climate has analyzed commit 68c61ef and detected 0 issues on this pull request.

View more on Code Climate.

@codecov
Copy link

codecov bot commented Aug 4, 2021

Codecov Report

Merging #419 (68c61ef) into main (6e8cf12) will decrease coverage by 62.06%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##             main     #419       +/-   ##
===========================================
- Coverage   87.58%   25.51%   -62.07%     
===========================================
  Files         102       94        -8     
  Lines        1651     1556       -95     
  Branches      264      255        -9     
===========================================
- Hits         1446      397     -1049     
- Misses        204     1157      +953     
- Partials        1        2        +1     
Impacted Files Coverage Δ
...igator/screens/Transactions/TransactionsScreen.tsx 0.00% <0.00%> (-84.62%) ⬇️
...s/Transactions/screens/TransactionDetailScreen.tsx 0.00% <ø> (-80.00%) ⬇️
...tor/screens/Transactions/screens/stateProcessor.ts 0.00% <ø> (-100.00%) ⬇️
app/store/index.ts 0.00% <0.00%> (-100.00%) ⬇️
app/screens/RootNavigator.tsx 0.00% <0.00%> (-100.00%) ⬇️
app/api/storage/provider/provider.ts 0.00% <0.00%> (-100.00%) ⬇️
app/screens/WalletNavigator/screens/Onboarding.tsx 0.00% <0.00%> (-100.00%) ⬇️
...vigator/screens/CreateWallet/PinCreationScreen.tsx 0.00% <0.00%> (-100.00%) ⬇️
...ator/screens/CreateWallet/CreateMnemonicWallet.tsx 0.00% <0.00%> (-100.00%) ⬇️
... and 52 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e8cf12...68c61ef. Read the comment docs.

@netlify
Copy link

netlify bot commented Aug 4, 2021

✔️ Deploy Preview for defi-wallet ready!

🔨 Explore the source changes: 68c61ef

🔍 Inspect the deploy log: https://app.netlify.com/sites/defi-wallet/deploys/610b2534d375970008a7e0cb

😎 Browse the preview: https://deploy-preview-419--defi-wallet.netlify.app

@defichain-bot
Copy link
Contributor

defichain-bot commented Aug 4, 2021

Build preview for DeFi Wallet is ready!

Built with commit ea911a5

https://expo.io/@defichain/wallet?release-channel=pr-preview-419

Since it is used in TransactionDetailScreen
@cypress
Copy link

cypress bot commented Aug 4, 2021



Test summary

126 0 0 0


Run details

Project wallet
Status Passed
Commit ea911a5 ℹ️
Started Aug 4, 2021 11:46 PM
Ended Aug 5, 2021 12:00 AM
Duration 13:44 💡
OS Linux Ubuntu - 20.04
Browser Chrome 92

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@kyleleow kyleleow requested a review from thedoublejay August 4, 2021 10:10
@kyleleow kyleleow marked this pull request as ready for review August 4, 2021 10:12
@thedoublejay thedoublejay enabled auto-merge (squash) August 4, 2021 23:40
@thedoublejay thedoublejay merged commit 8e6a794 into main Aug 5, 2021
@thedoublejay thedoublejay deleted the kengye/add-transaction-mediantime branch August 5, 2021 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui-ux kind/feature New feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

transactions - display medianTime for transactions
3 participants