Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): bottom sheet reduced motion #4183

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

pierregee
Copy link
Contributor

What this PR does / why we need it:

  • Possible fix on bottom sheet not opening on some devices
  • There are cases wherein the battery is low or reduced motion is enabled, the bottom sheet is not opening at all

Which issue(s) does this PR fixes?:

Fixes #

Additional comments?:

Developer Checklist:

  • Read your code changes at least once
  • Tested on iOS/Android device (e.g, No crashes, library supported etc.)
  • No console errors on web
  • Tested on Light mode and Dark mode*
  • Your UI implementation visually matched the rendered design*
  • Unit tests*
  • Added e2e tests*
  • Added translations*

Copy link
Contributor

Missing Translations Report

The following translations are missing for this pull request.

{
    "missingLanguageItems": {
        "zh-Hans": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 2054,
            "allLabels": "{}"
        },
        "zh-Hant": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 2054,
            "allLabels": "{}"
        },
        "fr": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 2054,
            "allLabels": "{}"
        },
        "es": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 2054,
            "allLabels": "{}"
        },
        "it": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 2054,
            "allLabels": "{}"
        }
    },
    "totalMissingCount": 0
}

Copy link
Contributor

Build preview for DeFiChain Wallet is ready!

Built with commit d230e05

https://expo.io/@defichain/wallet?release-channel=pr-preview-4183

@codecov-commenter
Copy link

codecov-commenter commented Apr 18, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 52.32%. Comparing base (bf3cd26) to head (f97a544).

Files Patch % Lines
mobile-app/app/components/BottomSheetInfo.tsx 0.00% 1 Missing ⚠️
mobile-app/app/components/BottomSheetWithNav.tsx 0.00% 1 Missing ⚠️
mobile-app/app/components/BottomSheetWithNavV2.tsx 0.00% 1 Missing ⚠️
...creens/TransactionAuthorization/PasscodePrompt.tsx 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4183      +/-   ##
==========================================
- Coverage   60.05%   52.32%   -7.73%     
==========================================
  Files         442      442              
  Lines       12577    12581       +4     
  Branches     4129     4129              
==========================================
- Hits         7553     6583     -970     
- Misses       4964     5944     +980     
+ Partials       60       54       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pierregee pierregee marked this pull request as ready for review April 18, 2024 08:57
@pierregee pierregee merged commit d1cd46b into main Apr 18, 2024
19 of 23 checks passed
@pierregee pierregee deleted the pierregee/reduce-motion-enabled-disable-animation branch April 18, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants