Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui-ux): UI for opt out anonymized data instrumentation #4177

Conversation

nattadex
Copy link
Contributor

What this PR does / why we need it:

Which issue(s) does this PR fixes?:

Fixes #DFC-481

Additional comments?:

Developer Checklist:

  • Read your code changes at least once
  • Tested on iOS/Android device (e.g, No crashes, library supported etc.)
  • No console errors on web
  • Tested on Light mode and Dark mode*
  • Your UI implementation visually matched the rendered design*
  • Unit tests*
  • Added e2e tests*
  • Added translations*

Copy link

linear bot commented Mar 28, 2024

@github-actions github-actions bot added area/ui-ux kind/feature New feature request labels Mar 28, 2024
Copy link
Contributor

github-actions bot commented Mar 28, 2024

Missing Translations Report

The following translations are missing for this pull request.

{
    "missingLanguageItems": {
        "zh-Hans": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 2054,
            "allLabels": "{}"
        },
        "zh-Hant": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 2054,
            "allLabels": "{}"
        },
        "fr": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 2054,
            "allLabels": "{}"
        },
        "es": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 2054,
            "allLabels": "{}"
        },
        "it": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 2054,
            "allLabels": "{}"
        }
    },
    "totalMissingCount": 0
}

Copy link
Contributor

github-actions bot commented Mar 28, 2024

Build preview for DeFiChain Wallet is ready!

Built with commit aa293ed

https://expo.io/@defichain/wallet?release-channel=pr-preview-4177

@codecov-commenter
Copy link

codecov-commenter commented Mar 28, 2024

Codecov Report

Attention: Patch coverage is 80.76923% with 15 lines in your changes are missing coverage. Please review.

Project coverage is 54.12%. Comparing base (bfe7b2d) to head (7d6d6d2).

Files Patch % Lines
shared/contexts/AnalyticsProvider.tsx 77.14% 7 Missing and 1 partial ⚠️
...gator/screens/Settings/screens/AnalyticsScreen.tsx 76.92% 3 Missing ⚠️
...obile-app/app/api/persistence/analytics_storage.ts 84.61% 2 Missing ⚠️
...p/app/components/OceanInterface/OceanInterface.tsx 71.42% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4177      +/-   ##
==========================================
- Coverage   59.92%   54.12%   -5.81%     
==========================================
  Files         439      442       +3     
  Lines       12506    12577      +71     
  Branches     4143     4129      -14     
==========================================
- Hits         7494     6807     -687     
- Misses       4952     5705     +753     
- Partials       60       65       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nattadex nattadex self-assigned this Mar 28, 2024
import { RootNavigator } from "./RootNavigator";

export function Main(): JSX.Element {
const { isLight } = useThemeContext();
useEffect(() => {
WalletAlert({
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets not add this alert in main component, I think lets create one separate component for this and include that component in portfolio page. So that we can reuse it for future alerts too

@chloezxyy
Copy link
Contributor

Left some linting issues to fix!

@pierregee pierregee marked this pull request as ready for review April 2, 2024 07:23
@pierregee pierregee merged commit bf3cd26 into main Apr 2, 2024
16 of 20 checks passed
@pierregee pierregee deleted the nicoletan/dfc-481-ui-for-opt-out-anonymized-data-instrumentation branch April 2, 2024 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants