-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ui-ux): UI for opt out anonymized data instrumentation #4177
feat(ui-ux): UI for opt out anonymized data instrumentation #4177
Conversation
Missing Translations ReportThe following translations are missing for this pull request. {
"missingLanguageItems": {
"zh-Hans": {
"missingCount": 0,
"labels": {},
"totalCount": 2054,
"allLabels": "{}"
},
"zh-Hant": {
"missingCount": 0,
"labels": {},
"totalCount": 2054,
"allLabels": "{}"
},
"fr": {
"missingCount": 0,
"labels": {},
"totalCount": 2054,
"allLabels": "{}"
},
"es": {
"missingCount": 0,
"labels": {},
"totalCount": 2054,
"allLabels": "{}"
},
"it": {
"missingCount": 0,
"labels": {},
"totalCount": 2054,
"allLabels": "{}"
}
},
"totalMissingCount": 0
} |
Build preview for DeFiChain Wallet is ready! Built with commit aa293ed https://expo.io/@defichain/wallet?release-channel=pr-preview-4177 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4177 +/- ##
==========================================
- Coverage 59.92% 54.12% -5.81%
==========================================
Files 439 442 +3
Lines 12506 12577 +71
Branches 4143 4129 -14
==========================================
- Hits 7494 6807 -687
- Misses 4952 5705 +753
- Partials 60 65 +5 ☔ View full report in Codecov by Sentry. |
mobile-app/app/screens/Main.tsx
Outdated
import { RootNavigator } from "./RootNavigator"; | ||
|
||
export function Main(): JSX.Element { | ||
const { isLight } = useThemeContext(); | ||
useEffect(() => { | ||
WalletAlert({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets not add this alert in main component, I think lets create one separate component for this and include that component in portfolio page. So that we can reuse it for future alerts too
Left some linting issues to fix! |
What this PR does / why we need it:
Which issue(s) does this PR fixes?:
Fixes #DFC-481
Additional comments?:
Developer Checklist: