Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): fixed issue of tokens not showing in EVM domain #4166

Merged
merged 2 commits into from
Jan 22, 2024

Conversation

nattadex
Copy link
Contributor

What this PR does / why we need it:

Which issue(s) does this PR fixes?:

Fixes #4163

Additional comments?:

Developer Checklist:

  • Read your code changes at least once
  • Tested on iOS/Android device (e.g, No crashes, library supported etc.)
  • No console errors on web
  • Tested on Light mode and Dark mode*
  • Your UI implementation visually matched the rendered design*
  • Unit tests*
  • Added e2e tests*
  • Added translations*

@nattadex nattadex linked an issue Jan 22, 2024 that may be closed by this pull request
Copy link
Contributor

Missing Translations Report

The following translations are missing for this pull request.

{
    "missingLanguageItems": {
        "zh-Hans": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 2042,
            "allLabels": "{}"
        },
        "zh-Hant": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 2042,
            "allLabels": "{}"
        },
        "fr": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 2042,
            "allLabels": "{}"
        },
        "es": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 2042,
            "allLabels": "{}"
        },
        "it": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 2042,
            "allLabels": "{}"
        }
    },
    "totalMissingCount": 0
}

Copy link
Contributor

github-actions bot commented Jan 22, 2024

Build preview for DeFiChain Wallet is ready!

Built with commit 4b2c5c8

https://expo.io/@defichain/wallet?release-channel=pr-preview-4166

@codecov-commenter
Copy link

codecov-commenter commented Jan 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f9dd1f1) 55.90% compared to head (24ed4fc) 53.79%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4166      +/-   ##
==========================================
- Coverage   55.90%   53.79%   -2.12%     
==========================================
  Files         438      438              
  Lines       12482    12485       +3     
  Branches     4134     4134              
==========================================
- Hits         6978     6716     -262     
- Misses       5419     5691     +272     
+ Partials       85       78       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pierregee pierregee marked this pull request as ready for review January 22, 2024 20:24
@pierregee pierregee merged commit d8400cf into main Jan 22, 2024
14 of 16 checks passed
@pierregee pierregee deleted the nicole/4163-dusd-evm-can-not-be-seen-in-light-wallet branch January 22, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DUSD EVM can not be seen in Light Wallet
3 participants