Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui-ux): call endpoint to save tx #4157

Merged
merged 11 commits into from
Feb 2, 2024
Merged

feat(ui-ux): call endpoint to save tx #4157

merged 11 commits into from
Feb 2, 2024

Conversation

chloezxyy
Copy link
Contributor

What this PR does / why we need it:

Which issue(s) does this PR fixes?:

Fixes #

Additional comments?:

Developer Checklist:

  • Read your code changes at least once
  • Tested on iOS/Android device (e.g, No crashes, library supported etc.)
  • No console errors on web
  • Tested on Light mode and Dark mode*
  • Your UI implementation visually matched the rendered design*
  • Unit tests*
  • Added e2e tests*
  • Added translations*

Copy link
Contributor

Missing Translations Report

The following translations are missing for this pull request.

{
    "missingLanguageItems": {
        "zh-Hans": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 2042,
            "allLabels": "{}"
        },
        "zh-Hant": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 2042,
            "allLabels": "{}"
        },
        "fr": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 2042,
            "allLabels": "{}"
        },
        "es": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 2042,
            "allLabels": "{}"
        },
        "it": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 2042,
            "allLabels": "{}"
        }
    },
    "totalMissingCount": 0
}

Copy link
Contributor

github-actions bot commented Dec 14, 2023

Build preview for DeFiChain Wallet is ready!

Built with commit ba2e1be

https://expo.io/@defichain/wallet?release-channel=pr-preview-4157

@codecov-commenter
Copy link

codecov-commenter commented Dec 14, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (b2d55e5) 55.94% compared to head (86c2572) 54.81%.

Files Patch % Lines
...p/app/components/OceanInterface/OceanInterface.tsx 66.66% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4157      +/-   ##
==========================================
- Coverage   55.94%   54.81%   -1.13%     
==========================================
  Files         438      438              
  Lines       12486    12501      +15     
  Branches     4135     4141       +6     
==========================================
- Hits         6985     6853     -132     
- Misses       5417     5564     +147     
  Partials       84       84              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -149,6 +149,26 @@ export function OceanInterface(): JSX.Element | null {
return vmmap.output;
};

useEffect(() => {
const saveTx = async (txId: string) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will save all tx for all network including testnet and playground

  1. Add checking that user is in mainnet
  2. Add feature flagging. To be able to disable this via feature flags in case something is wrong with the api

@pierregee pierregee merged commit c9e7f5d into main Feb 2, 2024
14 of 16 checks passed
@pierregee pierregee deleted the chloe/save-tx branch February 2, 2024 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui-ux kind/feature New feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants