Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui-ux): fixed address book forgets saved addresses when user switch to custom provider #4156

Merged
merged 1 commit into from
Jan 3, 2024

Conversation

fullstackninja864
Copy link
Contributor

@fullstackninja864 fullstackninja864 commented Dec 8, 2023

What this PR does / why we need it:

Which issue(s) does this PR fixes?:

Fixes #4147

Additional comments?:

Developer Checklist:

  • Read your code changes at least once
  • Tested on iOS/Android device (e.g, No crashes, library supported etc.)
  • No console errors on web
  • Tested on Light mode and Dark mode*
  • Your UI implementation visually matched the rendered design*
  • Unit tests*
  • Added e2e tests*
  • Added translations*

Copy link
Contributor

github-actions bot commented Dec 8, 2023

Missing Translations Report

The following translations are missing for this pull request.

{
    "missingLanguageItems": {
        "zh-Hans": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 2042,
            "allLabels": "{}"
        },
        "zh-Hant": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 2042,
            "allLabels": "{}"
        },
        "fr": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 2042,
            "allLabels": "{}"
        },
        "es": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 2042,
            "allLabels": "{}"
        },
        "it": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 2042,
            "allLabels": "{}"
        }
    },
    "totalMissingCount": 0
}

@fullstackninja864 fullstackninja864 changed the title fix(ui-ux): fixed address book forgets saved addresses when user swit… fix(ui-ux): fixed address book forgets saved addresses when user switch to custom provider Dec 8, 2023
Copy link
Contributor

github-actions bot commented Dec 8, 2023

Build preview for DeFiChain Wallet is ready!

Built with commit 499ee00

https://expo.io/@defichain/wallet?release-channel=pr-preview-4156

@codecov-commenter
Copy link

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (9aa2fb6) 56.00% compared to head (3011ace) 55.15%.

Files Patch % Lines
...screens/Settings/screens/ServiceProviderScreen.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4156      +/-   ##
==========================================
- Coverage   56.00%   55.15%   -0.86%     
==========================================
  Files         438      438              
  Lines       12482    12482              
  Branches     4134     4134              
==========================================
- Hits         6991     6884     -107     
- Misses       5406     5513     +107     
  Partials       85       85              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pierregee pierregee merged commit f9dd1f1 into main Jan 3, 2024
16 of 18 checks passed
@pierregee pierregee deleted the harsh/provider-bug branch January 3, 2024 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Address book forgets saved addresses when https://ocean.mydefichain.com is used as a provider
3 participants