Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui-ux): show reset btn on service provider screen without edit #4155

Merged
merged 5 commits into from
Jan 22, 2024

Conversation

fullstackninja864
Copy link
Contributor

What this PR does / why we need it:

Which issue(s) does this PR fixes?:

Fixes #

Additional comments?:

Developer Checklist:

  • Read your code changes at least once
  • Tested on iOS/Android device (e.g, No crashes, library supported etc.)
  • No console errors on web
  • Tested on Light mode and Dark mode*
  • Your UI implementation visually matched the rendered design*
  • Unit tests*
  • Added e2e tests*
  • Added translations*

Copy link
Contributor

github-actions bot commented Dec 8, 2023

Missing Translations Report

The following translations are missing for this pull request.

{
    "missingLanguageItems": {
        "zh-Hans": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 2042,
            "allLabels": "{}"
        },
        "zh-Hant": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 2042,
            "allLabels": "{}"
        },
        "fr": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 2042,
            "allLabels": "{}"
        },
        "es": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 2042,
            "allLabels": "{}"
        },
        "it": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 2042,
            "allLabels": "{}"
        }
    },
    "totalMissingCount": 0
}

Copy link
Contributor

github-actions bot commented Dec 8, 2023

Build preview for DeFiChain Wallet is ready!

Built with commit 72cb16f

https://expo.io/@defichain/wallet?release-channel=pr-preview-4155

@codecov-commenter
Copy link

codecov-commenter commented Dec 8, 2023

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (d8400cf) 55.08% compared to head (053e159) 55.01%.

Files Patch % Lines
...screens/Settings/screens/ServiceProviderScreen.tsx 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4155      +/-   ##
==========================================
- Coverage   55.08%   55.01%   -0.07%     
==========================================
  Files         438      438              
  Lines       12485    12486       +1     
  Branches     4134     4135       +1     
==========================================
- Hits         6877     6869       -8     
- Misses       5524     5530       +6     
- Partials       84       87       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fullstackninja864 fullstackninja864 self-assigned this Dec 12, 2023
@pierregee pierregee merged commit b2d55e5 into main Jan 22, 2024
14 of 16 checks passed
@pierregee pierregee deleted the harsh/reset-provider branch January 22, 2024 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants