Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui-ux): add linear gradient to from address on evm #4113

Merged
merged 2 commits into from
Nov 9, 2023

Conversation

lykalabrada
Copy link
Contributor

@lykalabrada lykalabrada commented Oct 26, 2023

What this PR does / why we need it:

Which issue(s) does this PR fixes?:

Fixes DFC-381

Additional comments?:

Developer Checklist:

  • Read your code changes at least once
  • Tested on iOS/Android device (e.g, No crashes, library supported etc.)
  • No console errors on web
  • Tested on Light mode and Dark mode*
  • Your UI implementation visually matched the rendered design*
  • Unit tests*
  • Added e2e tests*
  • Added translations*

@linear
Copy link

linear bot commented Oct 26, 2023

DFC-381 Transfer Domain : Linear Gradient not displayed for "From"address during Send

What happened?

Linear Gradient not displayed for "From"address during Send

What did you expect to happen?

How to reproduce it (as minimally and precisely as possible):

  1. User is on EVM network

  2. User sends token from EVM to DVM

    Linear_Gradient_Not_displayed.PNG

Anything else that the team needs to know?

@github-actions
Copy link
Contributor

github-actions bot commented Oct 26, 2023

Missing Translations Report

The following translations are missing for this pull request.

{
    "missingLanguageItems": {
        "zh-Hans": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 2029,
            "allLabels": "{}"
        },
        "zh-Hant": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 2029,
            "allLabels": "{}"
        },
        "fr": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 2029,
            "allLabels": "{}"
        },
        "es": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 2029,
            "allLabels": "{}"
        },
        "it": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 2029,
            "allLabels": "{}"
        }
    },
    "totalMissingCount": 0
}

@github-actions
Copy link
Contributor

github-actions bot commented Oct 26, 2023

Build preview for DeFiChain Wallet is ready!

Built with commit b128e0c

https://expo.io/@defichain/wallet?release-channel=pr-preview-4113

@codecov-commenter
Copy link

codecov-commenter commented Oct 26, 2023

Codecov Report

Merging #4113 (70c61ec) into main (b320ad0) will decrease coverage by 11.76%.
Report is 3 commits behind head on main.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##             main    #4113       +/-   ##
===========================================
- Coverage   61.50%   49.74%   -11.76%     
===========================================
  Files         438      438               
  Lines       12312    12358       +46     
  Branches     4069     4093       +24     
===========================================
- Hits         7572     6148     -1424     
- Misses       4649     6136     +1487     
+ Partials       91       74       -17     
Files Coverage Δ
mobile-app/app/components/SummaryTitle.tsx 61.76% <0.00%> (-24.45%) ⬇️

... and 102 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pierregee pierregee enabled auto-merge (squash) November 9, 2023 01:56
@pierregee pierregee disabled auto-merge November 9, 2023 01:57
@pierregee pierregee merged commit c074dcf into main Nov 9, 2023
11 of 15 checks passed
@pierregee pierregee deleted the lyka/fix-DFC-381 branch November 9, 2023 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants