Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui-ux): token name and logo incorrect in convert screen #4111

Merged
merged 1 commit into from
Oct 25, 2023

Conversation

lykalabrada
Copy link
Contributor

What this PR does / why we need it:

Which issue(s) does this PR fixes?:

Fixes DFC-388 DFC-380

Additional comments?:

Developer Checklist:

  • Read your code changes at least once
  • Tested on iOS/Android device (e.g, No crashes, library supported etc.)
  • No console errors on web
  • Tested on Light mode and Dark mode*
  • Your UI implementation visually matched the rendered design*
  • Unit tests*
  • Added e2e tests*
  • Added translations*

@linear
Copy link

linear bot commented Oct 25, 2023

DFC-388 Transfer Domain :[ADR] - Token name and logo incorrect in convert screen (EVM Network)

What happened?

Token name and logo incorrect in convert screen (EVM Network)

What did you expect to happen?

To Convert logo and token name should be of DVM network

linear_gradient_incorrect_dmst.jpg

logo_ incorrect.mp4

How to reproduce it (as minimally and precisely as possible):

Anything else that the team needs to know?

DFC-380 Transfer Domain : [iOS] - "Verified" is displayed instead of "Verified DVM address"in Send screen

What happened?

  1. Verified is displayed instead of "Verified Defichain (DVM) address"in Send screen
  2. Disclaimer " You are sending assets to a DFI address. EVM asset gets converted to DVM. Learn more" is missing

Issue 2 happens for EVM → DVM & DVM → EVM. Fix required for both flows.

"What did you expect to happen?

https://www.figma.com/file/2R0O9elwIN3fkkBnxLsUMM/Mobile-Light-Wallet---Handover-File?type=design&node-id=14331-178952&mode=design&t=eNiZ6gRY2hAwhYTW-4

How to reproduce it (as minimally and precisely as possible):

  1. User is in EVM network
  2. User clicks on send quick link
  3. Selects token and scans QR code for DVM address

Verified_DVM_Address_Expected.jpeg

Anything else that the team needs to know?

@github-actions
Copy link
Contributor

Missing Translations Report

The following translations are missing for this pull request.

{
    "missingLanguageItems": {
        "zh-Hans": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 2028,
            "allLabels": "{}"
        },
        "zh-Hant": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 2028,
            "allLabels": "{}"
        },
        "fr": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 2028,
            "allLabels": "{}"
        },
        "es": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 2028,
            "allLabels": "{}"
        },
        "it": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 2028,
            "allLabels": "{}"
        }
    },
    "totalMissingCount": 0
}

@lykalabrada lykalabrada merged commit b320ad0 into main Oct 25, 2023
11 of 15 checks passed
@lykalabrada lykalabrada deleted the harsh/fix-DFC-388 branch October 25, 2023 09:50
@github-actions
Copy link
Contributor

Build preview for DeFiChain Wallet is ready!

Built with commit 3176b9f

https://expo.io/@defichain/wallet?release-channel=pr-preview-4111

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants