Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ui-ux): updated twitter logo to its latest version #4010

Merged
merged 1 commit into from
Aug 2, 2023

Conversation

fullstackninja864
Copy link
Contributor

What this PR does / why we need it:

Which issue(s) does this PR fixes?:

Fixes #

Additional comments?:

Developer Checklist:

  • Read your code changes at least once
  • Tested on iOS/Android device (e.g, No crashes, library supported etc.)
  • No console errors on web
  • Tested on Light mode and Dark mode*
  • Your UI implementation visually matched the rendered design*
  • Unit tests*
  • Added e2e tests*
  • Added translations*

@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2023

Missing Translations Report

The following translations are missing for this pull request.

{
    "missingLanguageItems": {
        "zh-Hans": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 1988,
            "allLabels": "{}"
        },
        "zh-Hant": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 1988,
            "allLabels": "{}"
        },
        "fr": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 1988,
            "allLabels": "{}"
        },
        "es": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 1988,
            "allLabels": "{}"
        },
        "it": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 1988,
            "allLabels": "{}"
        }
    },
    "totalMissingCount": 0
}

@codecov-commenter
Copy link

codecov-commenter commented Aug 2, 2023

Codecov Report

Merging #4010 (11d750f) into main (4ee4bc9) will decrease coverage by 0.86%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #4010      +/-   ##
==========================================
- Coverage   57.90%   57.05%   -0.86%     
==========================================
  Files         459      460       +1     
  Lines       12347    12355       +8     
  Branches     4082     4084       +2     
==========================================
- Hits         7150     7049     -101     
- Misses       5109     5219     +110     
+ Partials       88       87       -1     
Files Changed Coverage Δ
...le-app/app/components/icons/assets/TwitterIcon.tsx 100.00% <100.00%> (ø)
...Navigator/screens/Settings/screens/AboutScreen.tsx 92.30% <100.00%> (+1.39%) ⬆️

... and 13 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2023

Build preview for DeFiChain Wallet is ready!

Built with commit 96ffd9f

https://expo.io/@defichain/wallet?release-channel=pr-preview-4010

Copy link
Contributor

@pierregee pierregee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated on dark and light mode!

@pierregee pierregee merged commit 7a57e57 into main Aug 2, 2023
@pierregee pierregee deleted the harsh/twitter-logo-update branch August 2, 2023 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui-ux kind/chore Non feature change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants