Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(e2e): network-detail-spec-fix #3994

Merged
merged 9 commits into from
Jul 6, 2023

Conversation

Rampraesath
Copy link
Contributor

What this PR does / why we need it:

  • Added 1 sec wait to allow elements to load properly before actions

Which issue(s) does this PR fixes?:

Fixes #

Additional comments?:

Developer Checklist:

  • Read your code changes at least once
  • Tested on iOS/Android device (e.g, No crashes, library supported etc.)
  • No console errors on web
  • Tested on Light mode and Dark mode*
  • Your UI implementation visually matched the rendered design*
  • Unit tests*
  • Added e2e tests*
  • Added translations*

@github-actions
Copy link
Contributor

github-actions bot commented Jul 4, 2023

Missing Translations Report

The following translations are missing for this pull request.

{
    "missingLanguageItems": {
        "zh-Hans": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 1988,
            "allLabels": "{}"
        },
        "zh-Hant": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 1988,
            "allLabels": "{}"
        },
        "fr": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 1988,
            "allLabels": "{}"
        },
        "es": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 1988,
            "allLabels": "{}"
        },
        "it": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 1988,
            "allLabels": "{}"
        }
    },
    "totalMissingCount": 0
}

@github-actions
Copy link
Contributor

github-actions bot commented Jul 4, 2023

Build preview for DeFiChain Wallet is ready!

Built with commit cc4b3c0

https://expo.io/@defichain/wallet?release-channel=pr-preview-3994

@Rampraesath Rampraesath marked this pull request as draft July 4, 2023 10:27
@Rampraesath Rampraesath changed the title added wait for element to load properly chore(e2e): network-detail-spec-fix Jul 4, 2023
@github-actions github-actions bot added the kind/chore Non feature change label Jul 4, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jul 4, 2023

Codecov Report

Merging #3994 (3e46ab6) into main (ba51400) will increase coverage by 1.27%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #3994      +/-   ##
==========================================
+ Coverage   56.46%   57.73%   +1.27%     
==========================================
  Files         459      459              
  Lines       12347    12347              
  Branches     4082     4082              
==========================================
+ Hits         6972     7129     +157     
+ Misses       5286     5130     -156     
+ Partials       89       88       -1     

see 16 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Rampraesath Rampraesath marked this pull request as ready for review July 5, 2023 07:24
@thedoublejay
Copy link
Contributor

thedoublejay commented Jul 6, 2023

@Rampraesath can update this conflict?

@thedoublejay sure, have resolved the conflict

@thedoublejay thedoublejay merged commit 8a46911 into main Jul 6, 2023
@thedoublejay thedoublejay deleted the ram/e2e-flaky-network-detail-fix branch July 6, 2023 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/chore Non feature change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants