Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

50% / max buttons for input fields #396

Merged
merged 21 commits into from
Aug 3, 2021
Merged

Conversation

kyleleow
Copy link
Contributor

@kyleleow kyleleow commented Aug 2, 2021

What kind of PR is this?:

/kind feature

What this PR does / why we need it:

  • Add functionality to quickly set 50% of the balance in input field

Which issue(s) does this PR fixes?:

Fixes #375

@kyleleow kyleleow self-assigned this Aug 2, 2021
@codeclimate
Copy link

codeclimate bot commented Aug 2, 2021

Code Climate has analyzed commit 53284d9 and detected 0 issues on this pull request.

View more on Code Climate.

@netlify
Copy link

netlify bot commented Aug 2, 2021

✔️ Deploy Preview for defi-wallet ready!

🔨 Explore the source changes: 53284d9

🔍 Inspect the deploy log: https://app.netlify.com/sites/defi-wallet/deploys/6108c42825777100075980dd

😎 Browse the preview: https://deploy-preview-396--defi-wallet.netlify.app

@codecov
Copy link

codecov bot commented Aug 2, 2021

Codecov Report

Merging #396 (53284d9) into main (b915adb) will increase coverage by 0.13%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #396      +/-   ##
==========================================
+ Coverage   87.00%   87.13%   +0.13%     
==========================================
  Files          93       94       +1     
  Lines        1400     1399       -1     
  Branches      208      210       +2     
==========================================
+ Hits         1218     1219       +1     
+ Misses        181      179       -2     
  Partials        1        1              
Impacted Files Coverage Δ
app/components/SetAmountButton.tsx 100.00% <100.00%> (ø)
...ns/AppNavigator/screens/Balances/ConvertScreen.tsx 95.71% <100.00%> (-0.29%) ⬇️
...pNavigator/screens/Balances/screens/SendScreen.tsx 90.74% <100.00%> (-0.17%) ⬇️
...reens/AppNavigator/screens/Dex/DexAddLiquidity.tsx 98.48% <100.00%> (+2.96%) ⬆️
...pNavigator/screens/Dex/PoolSwap/PoolSwapScreen.tsx 94.11% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b915adb...53284d9. Read the comment docs.

@defichain-bot
Copy link
Contributor

defichain-bot commented Aug 2, 2021

Build preview for DeFi Wallet is ready!

Built with commit f4a4074

https://expo.io/@defichain/wallet?release-channel=pr-preview-396

@cypress
Copy link

cypress bot commented Aug 2, 2021



Test summary

125 0 0 0


Run details

Project wallet
Status Passed
Commit f4a4074 ℹ️
Started Aug 3, 2021 4:23 AM
Ended Aug 3, 2021 4:36 AM
Duration 12:35 💡
OS Linux Ubuntu - 20.04
Browser Chrome 92

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

app/components/SetAmountButton.tsx Outdated Show resolved Hide resolved
app/components/SetAmountButton.tsx Outdated Show resolved Hide resolved
Using jquery escapeSelector() because cypress is running jquery under the hood
@kyleleow kyleleow marked this pull request as ready for review August 3, 2021 04:46
@kyleleow kyleleow requested a review from thedoublejay August 3, 2021 04:46
@thedoublejay thedoublejay merged commit 6043f80 into main Aug 3, 2021
@thedoublejay thedoublejay deleted the kengye/add-half-button branch August 3, 2021 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

50% / max buttons for input fields
3 participants