-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
50% / max buttons for input fields #396
Conversation
Refactor button jsx element Ref: Issue #375
In AddLiquidityScreen and PoolSwapScreen
For Send and PoolSwap screen
Code Climate has analyzed commit 53284d9 and detected 0 issues on this pull request. View more on Code Climate. |
✔️ Deploy Preview for defi-wallet ready! 🔨 Explore the source changes: 53284d9 🔍 Inspect the deploy log: https://app.netlify.com/sites/defi-wallet/deploys/6108c42825777100075980dd 😎 Browse the preview: https://deploy-preview-396--defi-wallet.netlify.app |
Codecov Report
@@ Coverage Diff @@
## main #396 +/- ##
==========================================
+ Coverage 87.00% 87.13% +0.13%
==========================================
Files 93 94 +1
Lines 1400 1399 -1
Branches 208 210 +2
==========================================
+ Hits 1218 1219 +1
+ Misses 181 179 -2
Partials 1 1
Continue to review full report at Codecov.
|
Build preview for DeFi Wallet is ready! Built with commit f4a4074 https://expo.io/@defichain/wallet?release-channel=pr-preview-396 |
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
Add DFI UTXO, DFI, and BTC into wallet To test 50% and MAX button
In ConvertScreen when 50% is pressed
app/screens/AppNavigator/screens/Balances/screens/SendScreen.tsx
Outdated
Show resolved
Hide resolved
Using jquery escapeSelector() because cypress is running jquery under the hood
What kind of PR is this?:
/kind feature
What this PR does / why we need it:
Which issue(s) does this PR fixes?:
Fixes #375