Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ocean interface - wait for transaction confirmation #395

Merged
merged 13 commits into from
Aug 3, 2021

Conversation

thedoublejay
Copy link
Member

What kind of PR is this?:

/kind feature

What this PR does / why we need it:

Ability to wait for transaction to be confirmed. Also, adds fetching of balance after a transaction.

Which issue(s) does this PR fixes?:

Fixes #306

Additional comments?:

@defichain-bot defichain-bot added the kind/feature New feature request label Aug 2, 2021
@thedoublejay thedoublejay changed the title add confirm step for ocean interface ocean interface - wait for transaction confirmation Aug 2, 2021
@codecov
Copy link

codecov bot commented Aug 2, 2021

Codecov Report

Merging #395 (bd250de) into main (58a0443) will decrease coverage by 0.38%.
The diff coverage is 76.74%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #395      +/-   ##
==========================================
- Coverage   87.13%   86.75%   -0.39%     
==========================================
  Files          94       94              
  Lines        1399     1434      +35     
  Branches      210      214       +4     
==========================================
+ Hits         1219     1244      +25     
- Misses        179      189      +10     
  Partials        1        1              
Impacted Files Coverage Δ
app/components/OceanInterface/OceanInterface.tsx 82.79% <72.97%> (-7.69%) ⬇️
...pNavigator/screens/Balances/screens/SendScreen.tsx 91.52% <100.00%> (+0.78%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58a0443...bd250de. Read the comment docs.

@netlify
Copy link

netlify bot commented Aug 2, 2021

✔️ Deploy Preview for defi-wallet ready!

🔨 Explore the source changes: bd250de

🔍 Inspect the deploy log: https://app.netlify.com/sites/defi-wallet/deploys/6108f482a59fd100074272e0

😎 Browse the preview: https://deploy-preview-395--defi-wallet.netlify.app/

@defichain-bot
Copy link
Contributor

defichain-bot commented Aug 2, 2021

Build preview for DeFi Wallet is ready!

Built with commit fb86622

https://expo.io/@defichain/wallet?release-channel=pr-preview-395

@cypress
Copy link

cypress bot commented Aug 2, 2021



Test summary

125 0 0 0


Run details

Project wallet
Status Passed
Commit fb86622 ℹ️
Started Aug 3, 2021 7:50 AM
Ended Aug 3, 2021 8:04 AM
Duration 14:25 💡
OS Linux Ubuntu - 20.04
Browser Chrome 92

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@codeclimate
Copy link

codeclimate bot commented Aug 2, 2021

Code Climate has analyzed commit bd250de and detected 0 issues on this pull request.

View more on Code Climate.

@thedoublejay thedoublejay marked this pull request as draft August 2, 2021 09:49
@thedoublejay thedoublejay marked this pull request as ready for review August 2, 2021 14:31
cypress/support/commands.ts Outdated Show resolved Hide resolved
app/components/OceanInterface/OceanInterface.tsx Outdated Show resolved Hide resolved
@thedoublejay thedoublejay merged commit aa7e090 into main Aug 3, 2021
@thedoublejay thedoublejay deleted the thedoublejay/ocean_interface_verify branch August 3, 2021 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ocean interface - wait for the transaction to be confirmed
4 participants