Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wallet - UI fixes #391

Merged
merged 3 commits into from
Aug 2, 2021
Merged

wallet - UI fixes #391

merged 3 commits into from
Aug 2, 2021

Conversation

thedoublejay
Copy link
Member

What kind of PR is this?:

/kind fix

What this PR does / why we need it:

  1. SectionTitle for CommunityScreen
  2. Update button label for remove liquidity
  3. Prevent NaN for Convert screen
  4. Don't show negative values for Convert Screen

Which issue(s) does this PR fixes?:

Fixes #387

Additional comments?:

@codeclimate
Copy link

codeclimate bot commented Aug 2, 2021

Code Climate has analyzed commit 6c1dc43 and detected 0 issues on this pull request.

View more on Code Climate.

@codecov
Copy link

codecov bot commented Aug 2, 2021

Codecov Report

Merging #391 (6c1dc43) into main (3b6b51f) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #391      +/-   ##
==========================================
- Coverage   87.95%   87.93%   -0.03%     
==========================================
  Files          92       92              
  Lines        1387     1384       -3     
  Branches      207      206       -1     
==========================================
- Hits         1220     1217       -3     
  Misses        166      166              
  Partials        1        1              
Impacted Files Coverage Δ
...vigator/screens/Balances/screens/ReceiveScreen.tsx 100.00% <ø> (ø)
...ns/AppNavigator/screens/Dex/DexRemoveLiquidity.tsx 94.11% <ø> (ø)
...gator/screens/Settings/screens/CommunityScreen.tsx 100.00% <ø> (ø)
...ns/AppNavigator/screens/Balances/ConvertScreen.tsx 96.00% <100.00%> (ø)
...reens/AppNavigator/screens/Dex/DexAddLiquidity.tsx 95.52% <100.00%> (-0.20%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b6b51f...6c1dc43. Read the comment docs.

@netlify
Copy link

netlify bot commented Aug 2, 2021

✔️ Deploy Preview for defi-wallet ready!

🔨 Explore the source changes: 6c1dc43

🔍 Inspect the deploy log: https://app.netlify.com/sites/defi-wallet/deploys/6107828ac46500000755d38c

😎 Browse the preview: https://deploy-preview-391--defi-wallet.netlify.app

fuxingloh
fuxingloh previously approved these changes Aug 2, 2021
@defichain-bot
Copy link
Contributor

defichain-bot commented Aug 2, 2021

Build preview for DeFi Wallet is ready!

Built with commit 464dede

https://expo.io/@defichain/wallet?release-channel=pr-preview-391

@cypress
Copy link

cypress bot commented Aug 2, 2021



Test summary

116 0 0 0


Run details

Project wallet
Status Passed
Commit 464dede ℹ️
Started Aug 2, 2021 5:31 AM
Ended Aug 2, 2021 5:46 AM
Duration 14:25 💡
OS Linux Ubuntu - 20.04
Browser Chrome 92

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@thedoublejay thedoublejay merged commit b915adb into main Aug 2, 2021
@thedoublejay thedoublejay deleted the thedoublejay/ui_fix branch August 2, 2021 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add liquidity - don't display NaN in input fields
3 participants