Small app/api/wallet refactoring
#332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code Climate has analyzed commit 536da19 and detected 0 issues on this pull request. View more on Code Climate. |
Missing Translations ReportThe following translations are missing for this pull request. View Full Report{
"zh-Hans": {
"missingCount": 96,
"labels": {
"screens/OceanInterface": [
"Transaction Sent",
"title",
"An error has occurred",
"OK"
],
"components/BarCodeScanner": [
"Requesting for camera permission",
"You have denied the permission request to use your camera"
],
"screens/WalletOnboarding": [
"No wallets"
],
"screens/WalletNavigator": [
"Wallets",
"Create Mnemonic Phrase",
"Verify Mnemonic Phrase",
"Restore Mnemonic Wallet"
],
"screens/LoadingScreen": [
"Loading"
],
"screens/ErrorBoundary": [
"Something went wrong",
"The app ran into a problem and could not recover. Please restart your application."
],
"screens/TransactionDetailScreen": [
"tx.desc)",
"tx.amount)",
"`${tx.block}`)",
"tx.txid"
],
"screens/TransactionsScreen": [
"desc",
"block",
"LOAD MORE",
"Transactions"
],
"screens/TransactionsDetailScreen": [
"Transaction"
],
"screens/CommunityScreen": [
"Connect with the community:",
"DeFiChain is a community-driven and open project.",
"The DeFiChain Foundation does not provide direct support.",
"title",
"Community"
],
"wallet/settings": [
"key",
"EXIT WALLET"
],
"screens/SettingsNavigator": [
"Settings"
],
"screens/PoolSwapScreen": [
"From",
"To",
"SWAP",
"Enter an amount",
"Balance: ",
"MAX",
"Price",
"Estimated to receive",
"Minimum to receive",
"Liquidity provider fee",
"Swapping Token"
],
"app/DexScreen": [
"section.key"
],
"screens/DexScreen": [
"SWAP",
"Decentralized Exchange",
"Add Liquidity",
"Remove Liquidity"
],
"screens/RemoveLiquidity": [
"Amount of liquidity to remove",
"Removing Liquidity"
],
"screens/AddLiquidity": [
"Price",
"`Token ${props.type === 'primary' ? 'A' : 'B'}`",
"Balance",
"MAX",
"per",
"Share of pool",
"Pooled "
],
"components/slider": [
"None"
],
"components": [
"All"
],
"components/Button": [
"CONTINUE"
],
"screens/ConfirmAddLiq": [
"Adding",
"Fee",
"Price",
"Liquidity tokens received",
"Share of pool",
"Pooled"
],
"screens/ConfirmLiquidity": [
"CONFIRM",
"Adding Liquidity"
],
"screens/SendScreen": [
"CONTINUE",
"Sending",
"Transaction fee",
"SEND",
"TO ADDRESS",
"Enter an address",
"Enter an amount",
"Balance: ",
"MAX",
"Wallet Send"
],
"screens/TokenDetailScreen": [
"AMOUNT BALANCE",
"AVAILABLE OPTIONS",
"Send to other wallet",
"Receive",
"Convert"
],
"screens/ReceiveScreen": [
"Use this address to receive DFI or any DST",
"Copy",
"Wallet Receive"
],
"screens/ConvertScreen": [
"PREVIEW CONVERSION",
"\"Tokens vs UTXO",
"Converting DFI",
"Convert DFIs",
"Scan recipient QR"
],
"screens/Convert": [
"titlePrefix",
"Balance"
],
"components/max": [
"MAX"
],
"screens/BalancesScreen": [
"BALANCE DETAILS",
"props.title",
"Wallet Balances"
]
},
"totalCount": 96
},
"zh-Hant": {
"missingCount": 95,
"labels": {
"screens/OceanInterface": [
"Transaction Sent",
"title",
"An error has occurred",
"OK"
],
"components/BarCodeScanner": [
"Requesting for camera permission",
"You have denied the permission request to use your camera"
],
"screens/WalletOnboarding": [
"No wallets"
],
"screens/WalletNavigator": [
"Wallets",
"Create Mnemonic Phrase",
"Verify Mnemonic Phrase",
"Restore Mnemonic Wallet"
],
"screens/LoadingScreen": [
"Loading"
],
"screens/ErrorBoundary": [
"Something went wrong",
"The app ran into a problem and could not recover. Please restart your application."
],
"screens/TransactionDetailScreen": [
"tx.desc)",
"tx.amount)",
"`${tx.block}`)",
"tx.txid"
],
"screens/TransactionsScreen": [
"desc",
"block",
"LOAD MORE"
],
"screens/TransactionsDetailScreen": [
"Transaction"
],
"screens/CommunityScreen": [
"Connect with the community:",
"DeFiChain is a community-driven and open project.",
"The DeFiChain Foundation does not provide direct support.",
"title",
"Community"
],
"wallet/settings": [
"key",
"EXIT WALLET"
],
"screens/SettingsNavigator": [
"Settings"
],
"screens/PoolSwapScreen": [
"From",
"To",
"SWAP",
"Enter an amount",
"Balance: ",
"MAX",
"Price",
"Estimated to receive",
"Minimum to receive",
"Liquidity provider fee",
"Swapping Token"
],
"app/DexScreen": [
"section.key"
],
"screens/DexScreen": [
"SWAP",
"Decentralized Exchange",
"Add Liquidity",
"Remove Liquidity"
],
"screens/RemoveLiquidity": [
"Amount of liquidity to remove",
"Removing Liquidity"
],
"screens/AddLiquidity": [
"Price",
"`Token ${props.type === 'primary' ? 'A' : 'B'}`",
"Balance",
"MAX",
"per",
"Share of pool",
"Pooled "
],
"components/slider": [
"None"
],
"components": [
"All"
],
"components/Button": [
"CONTINUE"
],
"screens/ConfirmAddLiq": [
"Adding",
"Fee",
"Price",
"Liquidity tokens received",
"Share of pool",
"Pooled"
],
"screens/ConfirmLiquidity": [
"CONFIRM",
"Adding Liquidity"
],
"screens/SendScreen": [
"CONTINUE",
"Sending",
"Transaction fee",
"SEND",
"TO ADDRESS",
"Enter an address",
"Enter an amount",
"Balance: ",
"MAX",
"Wallet Send"
],
"screens/TokenDetailScreen": [
"AMOUNT BALANCE",
"AVAILABLE OPTIONS",
"Send to other wallet",
"Receive",
"Convert"
],
"screens/ReceiveScreen": [
"Use this address to receive DFI or any DST",
"Copy",
"Wallet Receive"
],
"screens/ConvertScreen": [
"PREVIEW CONVERSION",
"\"Tokens vs UTXO",
"Converting DFI",
"Convert DFIs",
"Scan recipient QR"
],
"screens/Convert": [
"titlePrefix",
"Balance"
],
"components/max": [
"MAX"
],
"screens/BalancesScreen": [
"BALANCE DETAILS",
"props.title",
"Wallet Balances"
]
},
"totalCount": 96
},
"de": {
"missingCount": 95,
"labels": {
"screens/OceanInterface": [
"Transaction Sent",
"title",
"An error has occurred",
"OK"
],
"components/BarCodeScanner": [
"Requesting for camera permission",
"You have denied the permission request to use your camera"
],
"screens/WalletOnboarding": [
"No wallets"
],
"screens/WalletNavigator": [
"Wallets",
"Create Mnemonic Phrase",
"Verify Mnemonic Phrase",
"Restore Mnemonic Wallet"
],
"screens/LoadingScreen": [
"Loading"
],
"screens/ErrorBoundary": [
"Something went wrong",
"The app ran into a problem and could not recover. Please restart your application."
],
"screens/TransactionDetailScreen": [
"tx.desc)",
"tx.amount)",
"`${tx.block}`)",
"tx.txid"
],
"screens/TransactionsScreen": [
"desc",
"block",
"LOAD MORE"
],
"screens/TransactionsDetailScreen": [
"Transaction"
],
"screens/CommunityScreen": [
"Connect with the community:",
"DeFiChain is a community-driven and open project.",
"The DeFiChain Foundation does not provide direct support.",
"title",
"Community"
],
"wallet/settings": [
"key",
"EXIT WALLET"
],
"screens/SettingsNavigator": [
"Settings"
],
"screens/PoolSwapScreen": [
"From",
"To",
"SWAP",
"Enter an amount",
"Balance: ",
"MAX",
"Price",
"Estimated to receive",
"Minimum to receive",
"Liquidity provider fee",
"Swapping Token"
],
"app/DexScreen": [
"section.key"
],
"screens/DexScreen": [
"SWAP",
"Decentralized Exchange",
"Add Liquidity",
"Remove Liquidity"
],
"screens/RemoveLiquidity": [
"Amount of liquidity to remove",
"Removing Liquidity"
],
"screens/AddLiquidity": [
"Price",
"`Token ${props.type === 'primary' ? 'A' : 'B'}`",
"Balance",
"MAX",
"per",
"Share of pool",
"Pooled "
],
"components/slider": [
"None"
],
"components": [
"All"
],
"components/Button": [
"CONTINUE"
],
"screens/ConfirmAddLiq": [
"Adding",
"Fee",
"Price",
"Liquidity tokens received",
"Share of pool",
"Pooled"
],
"screens/ConfirmLiquidity": [
"CONFIRM",
"Adding Liquidity"
],
"screens/SendScreen": [
"CONTINUE",
"Sending",
"Transaction fee",
"SEND",
"TO ADDRESS",
"Enter an address",
"Enter an amount",
"Balance: ",
"MAX",
"Wallet Send"
],
"screens/TokenDetailScreen": [
"AMOUNT BALANCE",
"AVAILABLE OPTIONS",
"Send to other wallet",
"Receive",
"Convert"
],
"screens/ReceiveScreen": [
"Use this address to receive DFI or any DST",
"Copy",
"Wallet Receive"
],
"screens/ConvertScreen": [
"PREVIEW CONVERSION",
"\"Tokens vs UTXO",
"Converting DFI",
"Convert DFIs",
"Scan recipient QR"
],
"screens/Convert": [
"titlePrefix",
"Balance"
],
"components/max": [
"MAX"
],
"screens/BalancesScreen": [
"BALANCE DETAILS",
"props.title",
"Wallet Balances"
]
},
"totalCount": 96
}
} |
|
✔️ Deploy Preview for defi-wallet ready! 🔨 Explore the source changes: 536da19 🔍 Inspect the deploy log: https://app.netlify.com/sites/defi-wallet/deploys/60fa80e5ffc7e30007a082e6 😎 Browse the preview: https://deploy-preview-332--defi-wallet.netlify.app |
|
Build preview for DeFi Wallet is ready! Built with commit 4a1141d https://expo.io/@defichain/wallet?release-channel=pr-preview-332 |
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
Codecov Report
@@ Coverage Diff @@
## main #332 +/- ##
==========================================
+ Coverage 78.87% 79.18% +0.30%
==========================================
Files 87 87
Lines 1321 1321
Branches 191 191
==========================================
+ Hits 1042 1046 +4
+ Misses 278 274 -4
Partials 1 1
Continue to review full report at Codecov.
|
ivan-zynesis
approved these changes
Jul 23, 2021
fuxingloh
added a commit
that referenced
this pull request
Jul 23, 2021
* moved all network code into network.ts * updated persistence.ts * refactor provider * Fixed screen with wallet reference * added missing snapshot
fuxingloh
added a commit
that referenced
this pull request
Jul 23, 2021
* Bump defichain dependencies * Bump defichain dependencies * Small `app/api/wallet` refactoring (#332) * moved all network code into network.ts * updated persistence.ts * refactor provider * Fixed screen with wallet reference * added missing snapshot * Bump whale:0.5.11 * fixed totalLiquidity reference Co-authored-by: Fuxing Loh <[email protected]> Co-authored-by: Fuxing Loh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of PR is this?:
/kind refactor
What this PR does / why we need it:
Minor refactoring for better separation of code for wallet implementation and clarity.