font updates #322
Closed
font updates #322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thedoublejay
requested review from
fuxingloh,
ivan-zynesis and
izzycsy
as code owners
defichain-bot
added
area/assets
area/hooks
area/playground
area/ui-ux
kind/chore
|
Code Climate has analyzed commit 7cd8416 and detected 1 issue on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
Missing Translations ReportThe following translations are missing for this pull request. View Full Report{
"zh-Hans": {
"missingCount": 96,
"labels": {
"screens/OceanInterface": [
"Transaction Sent",
"title",
"An error has occurred",
"OK"
],
"components/BarCodeScanner": [
"Requesting for camera permission",
"You have denied the permission request to use your camera"
],
"screens/WalletOnboarding": [
"No wallets"
],
"screens/WalletNavigator": [
"Wallets",
"Create Mnemonic Phrase",
"Verify Mnemonic Phrase",
"Restore Mnemonic Wallet"
],
"screens/LoadingScreen": [
"Loading"
],
"screens/ErrorBoundary": [
"Something went wrong",
"The app ran into a problem and could not recover. Please restart your application."
],
"screens/TransactionDetailScreen": [
"tx.desc)",
"tx.amount)",
"`${tx.block}`)",
"tx.txid"
],
"screens/TransactionsScreen": [
"desc",
"block",
"LOAD MORE",
"Transactions"
],
"screens/TransactionsDetailScreen": [
"Transaction"
],
"screens/CommunityScreen": [
"Connect with the community:",
"DeFiChain is a community-driven and open project.",
"The DeFiChain Foundation does not provide direct support.",
"title",
"Community"
],
"wallet/settings": [
"key",
"EXIT WALLET"
],
"screens/SettingsNavigator": [
"Settings"
],
"screens/PoolSwapScreen": [
"From",
"To",
"SWAP",
"Enter an amount",
"Balance: ",
"MAX",
"Price",
"Estimated to receive",
"Minimum to receive",
"Liquidity provider fee",
"Swapping Token"
],
"app/DexScreen": [
"section.key"
],
"screens/DexScreen": [
"SWAP",
"Decentralized Exchange",
"Add Liquidity",
"Remove Liquidity"
],
"screens/RemoveLiquidity": [
"Amount of liquidity to remove",
"Removing Liquidity"
],
"screens/AddLiquidity": [
"Price",
"`Token ${props.type === 'primary' ? 'A' : 'B'}`",
"Balance",
"MAX",
"per",
"Share of pool",
"Pooled "
],
"components/slider": [
"None"
],
"components": [
"All"
],
"components/Button": [
"CONTINUE"
],
"screens/ConfirmAddLiq": [
"Adding",
"Fee",
"Price",
"Liquidity tokens received",
"Share of pool",
"Pooled"
],
"screens/ConfirmLiquidity": [
"CONFIRM",
"Adding Liquidity"
],
"screens/SendScreen": [
"CONTINUE",
"Sending",
"Transaction fee",
"SEND",
"TO ADDRESS",
"Enter an address",
"Enter an amount",
"Balance: ",
"MAX",
"Wallet Send"
],
"screens/TokenDetailScreen": [
"AMOUNT BALANCE",
"AVAILABLE OPTIONS",
"Send to other wallet",
"Receive",
"Convert"
],
"screens/ReceiveScreen": [
"Use this address to receive DFI or any DST",
"Copy",
"Wallet Receive"
],
"screens/ConvertScreen": [
"PREVIEW CONVERSION",
"\"Tokens vs UTXO",
"Converting DFI",
"Convert DFIs",
"Scan recipient QR"
],
"screens/Convert": [
"titlePrefix",
"Balance"
],
"components/max": [
"MAX"
],
"screens/BalancesScreen": [
"BALANCE DETAILS",
"props.title",
"Wallet Balances"
]
},
"totalCount": 96
},
"zh-Hant": {
"missingCount": 95,
"labels": {
"screens/OceanInterface": [
"Transaction Sent",
"title",
"An error has occurred",
"OK"
],
"components/BarCodeScanner": [
"Requesting for camera permission",
"You have denied the permission request to use your camera"
],
"screens/WalletOnboarding": [
"No wallets"
],
"screens/WalletNavigator": [
"Wallets",
"Create Mnemonic Phrase",
"Verify Mnemonic Phrase",
"Restore Mnemonic Wallet"
],
"screens/LoadingScreen": [
"Loading"
],
"screens/ErrorBoundary": [
"Something went wrong",
"The app ran into a problem and could not recover. Please restart your application."
],
"screens/TransactionDetailScreen": [
"tx.desc)",
"tx.amount)",
"`${tx.block}`)",
"tx.txid"
],
"screens/TransactionsScreen": [
"desc",
"block",
"LOAD MORE"
],
"screens/TransactionsDetailScreen": [
"Transaction"
],
"screens/CommunityScreen": [
"Connect with the community:",
"DeFiChain is a community-driven and open project.",
"The DeFiChain Foundation does not provide direct support.",
"title",
"Community"
],
"wallet/settings": [
"key",
"EXIT WALLET"
],
"screens/SettingsNavigator": [
"Settings"
],
"screens/PoolSwapScreen": [
"From",
"To",
"SWAP",
"Enter an amount",
"Balance: ",
"MAX",
"Price",
"Estimated to receive",
"Minimum to receive",
"Liquidity provider fee",
"Swapping Token"
],
"app/DexScreen": [
"section.key"
],
"screens/DexScreen": [
"SWAP",
"Decentralized Exchange",
"Add Liquidity",
"Remove Liquidity"
],
"screens/RemoveLiquidity": [
"Amount of liquidity to remove",
"Removing Liquidity"
],
"screens/AddLiquidity": [
"Price",
"`Token ${props.type === 'primary' ? 'A' : 'B'}`",
"Balance",
"MAX",
"per",
"Share of pool",
"Pooled "
],
"components/slider": [
"None"
],
"components": [
"All"
],
"components/Button": [
"CONTINUE"
],
"screens/ConfirmAddLiq": [
"Adding",
"Fee",
"Price",
"Liquidity tokens received",
"Share of pool",
"Pooled"
],
"screens/ConfirmLiquidity": [
"CONFIRM",
"Adding Liquidity"
],
"screens/SendScreen": [
"CONTINUE",
"Sending",
"Transaction fee",
"SEND",
"TO ADDRESS",
"Enter an address",
"Enter an amount",
"Balance: ",
"MAX",
"Wallet Send"
],
"screens/TokenDetailScreen": [
"AMOUNT BALANCE",
"AVAILABLE OPTIONS",
"Send to other wallet",
"Receive",
"Convert"
],
"screens/ReceiveScreen": [
"Use this address to receive DFI or any DST",
"Copy",
"Wallet Receive"
],
"screens/ConvertScreen": [
"PREVIEW CONVERSION",
"\"Tokens vs UTXO",
"Converting DFI",
"Convert DFIs",
"Scan recipient QR"
],
"screens/Convert": [
"titlePrefix",
"Balance"
],
"components/max": [
"MAX"
],
"screens/BalancesScreen": [
"BALANCE DETAILS",
"props.title",
"Wallet Balances"
]
},
"totalCount": 96
},
"de": {
"missingCount": 95,
"labels": {
"screens/OceanInterface": [
"Transaction Sent",
"title",
"An error has occurred",
"OK"
],
"components/BarCodeScanner": [
"Requesting for camera permission",
"You have denied the permission request to use your camera"
],
"screens/WalletOnboarding": [
"No wallets"
],
"screens/WalletNavigator": [
"Wallets",
"Create Mnemonic Phrase",
"Verify Mnemonic Phrase",
"Restore Mnemonic Wallet"
],
"screens/LoadingScreen": [
"Loading"
],
"screens/ErrorBoundary": [
"Something went wrong",
"The app ran into a problem and could not recover. Please restart your application."
],
"screens/TransactionDetailScreen": [
"tx.desc)",
"tx.amount)",
"`${tx.block}`)",
"tx.txid"
],
"screens/TransactionsScreen": [
"desc",
"block",
"LOAD MORE"
],
"screens/TransactionsDetailScreen": [
"Transaction"
],
"screens/CommunityScreen": [
"Connect with the community:",
"DeFiChain is a community-driven and open project.",
"The DeFiChain Foundation does not provide direct support.",
"title",
"Community"
],
"wallet/settings": [
"key",
"EXIT WALLET"
],
"screens/SettingsNavigator": [
"Settings"
],
"screens/PoolSwapScreen": [
"From",
"To",
"SWAP",
"Enter an amount",
"Balance: ",
"MAX",
"Price",
"Estimated to receive",
"Minimum to receive",
"Liquidity provider fee",
"Swapping Token"
],
"app/DexScreen": [
"section.key"
],
"screens/DexScreen": [
"SWAP",
"Decentralized Exchange",
"Add Liquidity",
"Remove Liquidity"
],
"screens/RemoveLiquidity": [
"Amount of liquidity to remove",
"Removing Liquidity"
],
"screens/AddLiquidity": [
"Price",
"`Token ${props.type === 'primary' ? 'A' : 'B'}`",
"Balance",
"MAX",
"per",
"Share of pool",
"Pooled "
],
"components/slider": [
"None"
],
"components": [
"All"
],
"components/Button": [
"CONTINUE"
],
"screens/ConfirmAddLiq": [
"Adding",
"Fee",
"Price",
"Liquidity tokens received",
"Share of pool",
"Pooled"
],
"screens/ConfirmLiquidity": [
"CONFIRM",
"Adding Liquidity"
],
"screens/SendScreen": [
"CONTINUE",
"Sending",
"Transaction fee",
"SEND",
"TO ADDRESS",
"Enter an address",
"Enter an amount",
"Balance: ",
"MAX",
"Wallet Send"
],
"screens/TokenDetailScreen": [
"AMOUNT BALANCE",
"AVAILABLE OPTIONS",
"Send to other wallet",
"Receive",
"Convert"
],
"screens/ReceiveScreen": [
"Use this address to receive DFI or any DST",
"Copy",
"Wallet Receive"
],
"screens/ConvertScreen": [
"PREVIEW CONVERSION",
"\"Tokens vs UTXO",
"Converting DFI",
"Convert DFIs",
"Scan recipient QR"
],
"screens/Convert": [
"titlePrefix",
"Balance"
],
"components/max": [
"MAX"
],
"screens/BalancesScreen": [
"BALANCE DETAILS",
"props.title",
"Wallet Balances"
]
},
"totalCount": 96
}
} |
|
✔️ Deploy Preview for defi-wallet ready! 🔨 Explore the source changes: 7cd8416 🔍 Inspect the deploy log: https://app.netlify.com/sites/defi-wallet/deploys/60fa1533af8c6a00073c68cc 😎 Browse the preview: https://deploy-preview-322--defi-wallet.netlify.app/ |
Codecov Report
@@ Coverage Diff @@
## main #322 +/- ##
==========================================
- Coverage 79.18% 76.22% -2.97%
==========================================
Files 86 80 -6
Lines 1326 1245 -81
Branches 191 183 -8
==========================================
- Hits 1050 949 -101
- Misses 275 294 +19
- Partials 1 2 +1
Continue to review full report at Codecov.
|
|
Build preview for DeFi Wallet is ready! Built with commit aca1481 https://expo.io/@defichain/wallet?release-channel=pr-preview-322 |
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
fuxingloh
suggested changes
Jul 22, 2021
app/components/Text.tsx
Outdated
| export const Default = StyleSheet.create({ | ||
| text: { | ||
| fontSize: 16, | ||
| fontWeight: '400', |
There was a problem hiding this comment.
can this be automatically be handled by tailwind?
app/components/Text.tsx
Outdated
|
|
||
| export type FontWeight = 'light' | 'regular' | 'medium' | 'semibold' | 'bold' | ||
|
|
||
| export const HeaderFont = { headerTitleStyle: { fontFamily: FontFaces.SemiBoldFont } } |
There was a problem hiding this comment.
can this be automatically be handled by tailwind within the Navigator that needs it?
# Conflicts: # app/components/SectionTitle.tsx # app/components/Text.tsx # app/components/index.tsx # app/screens/AppNavigator/BottomTabNavigator.tsx # app/screens/AppNavigator/screens/Balances/BalancesNavigator.tsx # app/screens/AppNavigator/screens/Balances/BalancesScreen.tsx # app/screens/AppNavigator/screens/Dex/DexNavigator.tsx # app/screens/AppNavigator/screens/Settings/SettingsNavigator.tsx # app/screens/AppNavigator/screens/Transactions/TransactionsNavigator.tsx # app/screens/PlaygroundNavigator/PlaygroundNavigator.tsx # app/screens/WalletNavigator/WalletNavigator.tsx
Merged
|
@fuxingloh I have created a new branch. Please use this link for the new PR - #325 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of PR is this?:
/kind chore
What this PR does / why we need it:
Tested them on Android and iOS
Which issue(s) does this PR fixes?:
Fixes #296
Additional comments?: