Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow DFI payment for DUSD loans #1965

Closed
5 tasks
thedoublejay opened this issue Jan 21, 2022 · 3 comments · Fixed by #2066
Closed
5 tasks

allow DFI payment for DUSD loans #1965

thedoublejay opened this issue Jan 21, 2022 · 3 comments · Fixed by #2066
Assignees
Labels
area/ui-ux kind/feature New feature request priority/important-soon Will be important soon triage/accepted Triage has been accepted
Milestone

Comments

@thedoublejay
Copy link
Member

thedoublejay commented Jan 21, 2022

What would you like to be added:

Based on DeFiCh/dfips#99, we would like to allow payment of DUSD loans only with DFI.
Additional context: https://github.com/DeFiCh/ain-private/issues/3

When paying using DFI, there's a 1% fee imposed. Need to have this design as well.

Requirements:

  • Add a feature flag which will be set to Public
  • Add this feature only for DUSD loans
  • Need to check on the API on which parameters to pass if DFI is used as loan payment
  • E2E tests
  • When paying using DFI, there's a 1% fee imposed

image

@thedoublejay thedoublejay added the kind/feature New feature request label Jan 21, 2022
@defichain-bot defichain-bot added the needs/triage Waiting for triage to be accepted label Jan 21, 2022
@defichain-bot
Copy link
Contributor

@thedoublejay: Thanks for opening an issue, it is currently awaiting triage.

The triage/accepted label can be added by foundation members by writing /triage accepted in a comment.

Details

I am a bot created to help the DeFiCh developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the DeFiCh/oss-governance-bot repository.

@defichain-bot defichain-bot added the needs/area Needs area label(s) label Jan 21, 2022
@defichain-bot
Copy link
Contributor

@thedoublejay: There are no 'area' labels on this issue. Adding an appropriate label will greatly expedite the process for us. You can add as many area as you see fit. If you are unsure what to do you can ignore this!

You can add area labels by leaving a /area comment.

Details

I am a bot created to help the DeFiCh developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the DeFiCh/oss-governance-bot repository.

@thedoublejay thedoublejay added this to the 1.0.1 milestone Jan 23, 2022
@thedoublejay thedoublejay added area/ui-ux triage/accepted Triage has been accepted priority/important-soon Will be important soon and removed needs/area Needs area label(s) needs/triage Waiting for triage to be accepted labels Jan 23, 2022
@thedoublejay thedoublejay changed the title allow DFI payment for loans allow DFI payment for DUSD loans Jan 27, 2022
@thedoublejay thedoublejay modified the milestones: 1.1.0, 1.2.0 Jan 27, 2022
@ngyingzhong
Copy link

Translations

DE

Loan details = Details zum Darlehen

With interest = zzgl. Zins

How much of the loan do you want to pay? = Wie viel des Darlehens willst du zurückzahlen? 

Select payment token = Token für die Zahlung auswählen

A 1% fee is applied when you pay with DFI = Wenn du mit DFI bezahlst, wird eine Gebühr von 1% erhoben

Read more = Mehr dazu

Amount to pay = Zu zahlender Betrag

Resulting (token; e.g. DFI or DUSD) balanced = Ergibt (DFI oder DUSD) 

Vault = Vault

Excess amount = Überschüssiger Betrag

Paying (amount) as loan payment. = Rückzahlung eines Darlehenbetrags von (amount)

FR

Loan details = Détails du prêt

With interest = ac intérêts de

How much of the loan do you want to pay? = Quelle part du prêt voulez-vous rembourser?

Select payment token = Sélectionner le token de remboursement

A 1% fee is applied when you pay with DFI = Des frais de 1% sont appliqués quand vous payez en DFI

Read more = En savoir plus

Amount to pay = Montant à payer

Resulting (token; e.g. DFI or DUSD) balanced = Tokens (DFI ou DUSD) restant

Vault = Vault

Excess amount = Montant excédant

Paying (amount) as loan payment. = Paiement de (amount) en remboursement du prêt

ZHT

Pending

ZHS

Pending

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui-ux kind/feature New feature request priority/important-soon Will be important soon triage/accepted Triage has been accepted
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants