Skip to content

Commit

Permalink
fix(ui-ux): fix selection of whitelisted address that redirects to ed…
Browse files Browse the repository at this point in the history
…it address (#4040)

* fix(ui-ux): fix selection of whitelisted address that redirects to edit address

* chore(test): update snapshot
  • Loading branch information
lykalabrada authored Oct 4, 2023
1 parent 31cd4ab commit fd79b4d
Show file tree
Hide file tree
Showing 5 changed files with 214 additions and 29 deletions.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -305,6 +305,8 @@ export function AddressBookScreen({ route, navigation }: Props): JSX.Element {
: addressDetail.address,
);
}
} else {
onDFIAddressClick();
}
};

Expand Down Expand Up @@ -340,9 +342,7 @@ export function AddressBookScreen({ route, navigation }: Props): JSX.Element {
]}
testID={`address_row_${index}_${testIDSuffix}`}
disabled={isDisabledToSelect}
onPress={async () => {
onChangeAddress(item);
}}
onPress={async () => onChangeAddress(item)}
>
<View
style={tailwind("flex flex-row items-center flex-grow", {
Expand Down Expand Up @@ -380,14 +380,7 @@ export function AddressBookScreen({ route, navigation }: Props): JSX.Element {
<View style={tailwind("flex flex-row items-center flex-auto")}>
<View style={tailwind("flex flex-auto mr-1")}>
{item.label !== "" && (
<TouchableOpacity
activeOpacity={0.7}
onPress={onDFIAddressClick}
style={tailwind("flex flex-row items-center")}
disabled={
activeButtonGroup === ButtonGroupTabKey.YourAddress
}
>
<>
<ThemedTextV2
style={tailwind("font-semibold-v2 text-sm min-w-0")}
testID={`address_row_label_${index}_${testIDSuffix}`}
Expand All @@ -413,7 +406,7 @@ export function AddressBookScreen({ route, navigation }: Props): JSX.Element {
</Text>
</LinearGradient>
)}
</TouchableOpacity>
</>
)}
{/* for DFI address */}
<YourAddressLink
Expand All @@ -423,7 +416,7 @@ export function AddressBookScreen({ route, navigation }: Props): JSX.Element {
displayIcon={
activeButtonGroup === ButtonGroupTabKey.YourAddress
}
onClick={onDFIAddressClick}
onClick={async () => onChangeAddress(item)}
/>
{/* for EVM address */}
{activeButtonGroup === ButtonGroupTabKey.YourAddress && (
Expand All @@ -442,19 +435,13 @@ export function AddressBookScreen({ route, navigation }: Props): JSX.Element {
</View>
{!enableAddressSelect &&
activeButtonGroup === ButtonGroupTabKey.Whitelisted && (
<TouchableOpacity
activeOpacity={0.7}
onPress={onDFIAddressClick}
style={tailwind("flex flex-row items-center")}
>
<ThemedIcon
dark={tailwind("text-mono-dark-v2-700")}
light={tailwind("text-mono-light-v2-700")}
iconType="Feather"
name="chevron-right"
size={18}
/>
</TouchableOpacity>
<ThemedIcon
dark={tailwind("text-mono-dark-v2-700")}
light={tailwind("text-mono-light-v2-700")}
iconType="Feather"
name="chevron-right"
size={18}
/>
)}
</View>
</View>
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit fd79b4d

Please sign in to comment.