Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented is_trained() and fixed bug for duplicate training on Parametric Models #32

Merged
merged 9 commits into from
Nov 30, 2023

Conversation

FirdausChoudhury
Copy link
Collaborator

@FirdausChoudhury FirdausChoudhury commented Nov 28, 2023

This fixed #26

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@BirkhoffG BirkhoffG self-requested a review November 30, 2023 18:44
@BirkhoffG BirkhoffG changed the base branch from 26-fix-bugs-on-training-parametric-models to master November 30, 2023 19:06
@BirkhoffG
Copy link
Owner

Did some local changes on my own. LGTM if the CI passes.

@BirkhoffG BirkhoffG merged commit 700e591 into BirkhoffG:master Nov 30, 2023
4 checks passed
@FirdausChoudhury FirdausChoudhury deleted the training_param_bugs branch December 8, 2023 21:27
@FirdausChoudhury FirdausChoudhury restored the training_param_bugs branch December 8, 2023 21:27
@FirdausChoudhury FirdausChoudhury deleted the training_param_bugs branch December 8, 2023 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix bugs on training Parametric Models
2 participants