Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tutorials on ReLax as a Recourse Library #19

Merged
merged 4 commits into from
Nov 9, 2023
Merged

Tutorials on ReLax as a Recourse Library #19

merged 4 commits into from
Nov 9, 2023

Conversation

Praneyg
Copy link
Collaborator

@Praneyg Praneyg commented Nov 8, 2023

This resolves #17

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

nbs/tutorials/methods.ipynb Show resolved Hide resolved
nbs/tutorials/methods.ipynb Show resolved Hide resolved
nbs/tutorials/methods.ipynb Show resolved Hide resolved
nbs/tutorials/methods.ipynb Show resolved Hide resolved
Copy link
Owner

@BirkhoffG BirkhoffG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check my comments on ReviewNB, and try to address all of them.

Another comment: If you mention an object in the text, mark them using ``. For example,

VanillaCF -> `VanillaCF` 

By decorating with backtick, you will create a link the documentation system.

Copy link
Owner

@BirkhoffG BirkhoffG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made some changes on my own. Looks good to me now.

@BirkhoffG BirkhoffG merged commit 51d55df into master Nov 9, 2023
4 checks passed
@BirkhoffG BirkhoffG deleted the tutorial branch November 9, 2023 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve the Tutorial for using relax.methods
2 participants