Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #78, use alphabetical order #79

Merged
merged 5 commits into from
Sep 15, 2023
Merged

Fix #78, use alphabetical order #79

merged 5 commits into from
Sep 15, 2023

Conversation

anakojm
Copy link
Contributor

@anakojm anakojm commented Sep 3, 2023

Fix #78

Use alphabetical order in desktop files list, to sort by application name instead of filename.

anakojm and others added 4 commits April 8, 2023 10:56
in desktop files list, by application name instead of filename
cleanup personal change
@anakojm anakojm changed the title top-down Fix #78, use alphabetical order Sep 3, 2023
@Biont
Copy link
Owner

Biont commented Sep 14, 2023

It feels to me like this would better be solved right in the list-entries function instead of this place, which is really just about mapping specific script parameters to internal functions. IMO we should not add logic in this area.

Is there a reason it cannot be done in the function itself?

@Biont Biont merged commit c8afcb8 into Biont:master Sep 15, 2023
1 check passed
@Biont
Copy link
Owner

Biont commented Sep 15, 2023

Thank you very much

@anakojm anakojm deleted the Alphabetical-order branch September 15, 2023 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Entries are sorted by .desktop filename, not app name
2 participants