Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements to occDetFunc tests and dependency function tests #257

Merged
merged 24 commits into from
Apr 11, 2024
Merged

Improvements to occDetFunc tests and dependency function tests #257

merged 24 commits into from
Apr 11, 2024

Conversation

DylanCarbone
Copy link
Collaborator

DylanCarbone and others added 21 commits January 25, 2024 12:10
@DylanCarbone
small fix to example code of formatOccData function, and fix packages…
da2058e 
… loaded check error in occDetFun function.
@DylanCarbone
Updates to documentation and removed commented code I made trying to …
3a8ed6e 
…fix an issue
@DylanCarbone
ErrorChecks.R function written with improved format and helper file, …
042ccd2 
…added skip for GHA
@DylanCarbone
Merge pull request #1 from DylanCarbone/master
c048e9c 
ErrorChecks.R function written with improved format and helper file, …
@DylanCarbone
test of appveyor
92bc8bb
@DylanCarbone
could not setup appveyor
a8fd669
@DylanCarbone
Merge pull request #2 from DylanCarbone/master
297dce4 
test of appveyor
@DylanCarbone
trial of CI with github actions
1efa9df
@DylanCarbone
fix of minor error
38fa989
@DylanCarbone
fix of syntax error
e748fe4
@DylanCarbone
review of CI errors
4c15cbd
@DylanCarbone
minor test fix to plot_DetectionPhenology
e3bc003
@DylanCarbone
added specification not compile manuals to due to absence of pdflatex…
68b4779 
… errors
@DylanCarbone
fix of test errors
11eb01e
@DylanCarbone
added test skips in absence of JAGS
c55f2d3
@DylanCarbone
fix of small error
360ee49
@DylanCarbone
fix of description syntax
2b89435
@DylanCarbone
test removal of remotes BRCindicators installation
83de4bc
@DylanCarbone
attempt to fix inst/doc warning
2d2998d
@DylanCarbone
fix of R CMD check warning
e71345b
@DylanCarbone
Attempt to fix warnings; changed description of gridref_regions rda f…
eac3f8f 
…ile to gridref_regions instead of test
@DylanCarbone
Copy link
Collaborator Author

Hi @AugustT,

Thank you for your patience on this. To give a quick update, the R CMD check now completes successfully for the Windows and MacOS environments. However tests within the Ubuntu environments are failing due to errors associated with installing Frescalo. The error messages can be seen here here

I'll try to fix this installation issue this week.

Thanks,

Dylan

@AugustT
Copy link
Member

AugustT commented Apr 9, 2024

Thanks Dylan. In the meantime shall we merge in the changes seeing as you have it passing on Windows and Mac?

@DylanCarbone
Copy link
Collaborator Author

Hi @AugustT,

That would be great, thank you. Appveyor is still reporting an error, but I believe this is because I have deleted it's yml file. As you can see here, the pull request check passes on windows and mac OS.

Thanks,

Dylan

@AugustT AugustT merged commit 3c1ef21 into BiologicalRecordsCentre:master Apr 11, 2024
2 of 6 checks passed
@AugustT
Copy link
Member

AugustT commented Apr 11, 2024

@DylanCarbone I have made the merge, fingers crossed this worked okay!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DylanCarbone @AugustT