Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed inconsistencies in plot_DetectionOverTime() & occDetModel() #233

Merged
merged 6 commits into from
Mar 29, 2021

Conversation

drnickisaac
Copy link
Contributor

  1. plot_DetectionOverTime() now works with "nolistlength" option. It also now implements the user-defined width of CI, rather than hard-coding 95%.
  2. occDetModel() now allows a number of recently added options already present in occDetFunc() and formatOccData(), including closure_period, replicate, criterion and provenance

This PR fixes issues #231 & #232

Merge branch 'master' of https://github.com/drnickisaac/sparta

# Conflicts:
#	R/plot_DetectionOverTime.R
1) plot_DetectionOverTime() now works with "nolistlength" option. It also now implements the user-defined width of CI, rather than hard-coding 95%.
2) occDetModel() now allows a number of recently added options already present in occDetFunc() and formatOccData(), including `closure_period`, `replicate`, `criterion` and `provenance`
@drnickisaac drnickisaac requested a review from AugustT March 27, 2021 20:49
Copy link
Member

@AugustT AugustT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@drnickisaac A couple of minor issues to address

R/occDetModel.r Show resolved Hide resolved
appveyor.yml Outdated Show resolved Hide resolved
…ed in order to match the order in the function call.
Copy link
Member

@AugustT AugustT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, these changes address the issues I raise

@AugustT AugustT merged commit 14919c1 into BiologicalRecordsCentre:master Mar 29, 2021
@drnickisaac
Copy link
Contributor Author

Thanks Tom.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants