Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for errorChecks #147

Merged
merged 2 commits into from
Apr 11, 2019

Conversation

FrancescaMancini
Copy link
Contributor

No description provided.

@AugustT
Copy link
Member

AugustT commented Apr 10, 2019

This failure is not your issue, I'm working on it

@AugustT
Copy link
Member

AugustT commented Apr 11, 2019

@FrancescaMancini Can you update your local version of sparta using 'git pull upstream master' in the git bash. Once you have done that push your local version up to your repository on Github, this will update your pull request automatically and should fix the issue.

@codecov-io
Copy link

codecov-io commented Apr 11, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@f699487). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #147   +/-   ##
=========================================
  Coverage          ?   56.39%           
=========================================
  Files             ?       81           
  Lines             ?     2766           
  Branches          ?        0           
=========================================
  Hits              ?     1560           
  Misses            ?     1206           
  Partials          ?        0
Impacted Files Coverage Δ
R/errorChecks.r 98.4% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f699487...34cd906. Read the comment docs.

@AugustT
Copy link
Member

AugustT commented Apr 11, 2019

@FrancescaMancini All seems to work now!

@AugustT AugustT merged commit 8b17947 into BiologicalRecordsCentre:master Apr 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants