Add "bp-" prefix to prevent class collapse #9 #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh wow nice! Thanks a lot!!! |
|
Yes, have a lot of places to test it, hahaha But, apparently, it works 😹 |
|
Have you news about it? |
|
@BioPhoton Can I merge it? 🤔 |
|
Hi @felipefialho ! Thanks for the PR (a little late). @billyjov and I discussed the prefix and we would prefer to go with sr (star-rating) as independent of an account. Would it be OK for you to change this? |
|
Hi @BioPhoton, I agree with this new approach but I don't have time to adjust it anymore :( If you can, is a good idea use my branch because already have the prefix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I test it using the styleguide 🍕😄
But the
distfolder also has the same files ofsrc, I've don't know if it is a problem.Can you test it? @BioPhoton