fix: add missing tsconfig props and mark some todos

BioPhoton · Nov 24, 2021 · 0579b92 · 0579b92
1 parent 532b6dc
commit 0579b92
Show file tree

Hide file tree

Showing 6 changed files with 7 additions and 5 deletions.
diff --git a/apps/angular5-example/src/app/app.module.ts b/apps/angular5-example/src/app/app.module.ts
@@ -3,7 +3,7 @@ import { NgModule } from '@angular/core';
 import { ReactiveFormsModule } from '@angular/forms';
 import { BrowserModule } from '@angular/platform-browser';
 import { RouterModule } from '@angular/router';
-// import { NxModule } from '@nrwl/nx';
+
 import { AppComponent } from './app.component';
 import { EventBindingsComponent } from './components/event-bindings/event-bindings.component';
 import { FormControlStarRatingComponent } from './components/form-control-star-rating/form-control-star-rating.component';
@@ -23,7 +23,6 @@ const DECLARATIONS = [
 @NgModule({
   imports: [
     BrowserModule,
-    // NxModule.forRoot(),
     ReactiveFormsModule,
     StarRatingModule.forRoot(),
     StaticModuleModule,

diff --git a/apps/angular5-example/src/app/components/custom-style/custom-style.component.scss b/apps/angular5-example/src/app/components/custom-style/custom-style.component.scss
@@ -2,6 +2,7 @@ $color-negative-rating: #ffff00;
 $color-ok-rating: #00ff00;
 $color-positive-rating: #ff00ff;
 $color-default-rating: #00f;
+// TODO: fix after css-star-rating refactoring.
 // @import "~css-star-rating/scss/star-rating";
 
 .rating.color-ok .star-container .star svg {

diff --git a/apps/angular5-example/src/styles.scss b/apps/angular5-example/src/styles.scss
@@ -6,6 +6,7 @@
 
 $fa-font-path: 'assets/fontawesome/webfonts';
 @import 'assets/fontawesome/css/fontawesome-all.min.css';
+// TODO: fix after css-star-rating refactoring.
 // @import "assets/fontawesome/scss/fontawesome";
 // @import "assets/fontawesome/scss/fa-brands";
 // @import "assets/fontawesome/scss/fa-regular";

diff --git a/apps/angular5-example/tsconfig.app.json b/apps/angular5-example/tsconfig.app.json
@@ -4,7 +4,7 @@
     "outDir": "../../dist/out-tsc/apps/angular5-example",
     "types": ["node"]
   },
-  "include": ["src/**/*.ts", "src/**/*.d.ts", "../../libs/mymodule/index.ts"],
+  "include": ["src/**/*.ts", "src/**/*.d.ts"],
   "exclude": ["**/*.spec.ts"],
   "files": ["src/main.ts", "src/polyfills.ts"]
 }
diff --git a/apps/angular5-example/tsconfig.packaged.json b/apps/angular5-example/tsconfig.packaged.json
@@ -2,7 +2,7 @@
   "extends": "../../tsconfig.packaged.json",
   "compilerOptions": {
     "outDir": "../../dist/apps/angular5-example-packaged",
-    "module": "es2015"
+    "module": "esnext"
   },
   "include": ["**/*.ts"],
   "exclude": ["**/*.spec.ts"]

diff --git a/tsconfig.base.json b/tsconfig.base.json
@@ -20,5 +20,6 @@
       "@angular-star-rating-lib/*": ["libs/*"]
     }
   },
-  "exclude": ["node_modules", "tmp"]
+  "exclude": ["node_modules", "tmp"],
+  "rootDir": "."
 }