Merge code for Kmer type from BioSequences to this package #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author: BenJWard <[email protected]>
jakobnissen
approved these changes
Apr 28, 2021
Comment on lines
+267
to
+271
| #@inline encoded_data_type(::Type{BigMer{A,K}}) where {A,K} = UInt128 | ||
| #@inline encoded_data_type(x::AbstractMer) = encoded_data_type(typeof(x)) | ||
| #@inline encoded_data(x::AbstractMer) = reinterpret(encoded_data_type(typeof(x)), x) | ||
| #@inline ksize(::Type{T}) where {A,K,T<:AbstractMer{A,K}} = K | ||
| #@inline Base.unsigned(x::AbstractMer) = encoded_data(x) |
There was a problem hiding this comment.
Some commented out sections here, and below, and also a bunch of whitespace above this.
|
I should get moving on that BioSequences update. It seems like you lean on the interface for this package! |
|
I'd prefer if BioSequences hit v3 before I properly massage this to work with the new interface yeah. Then once this is a decent version based on v3, I can work on kmer-counting, spectras, and the genome assembly stuff again. |
TransGirlCodes
changed the title
|
I'm going to merge this just to get the code as it is onto master. Then we'll do a few PRs to massage the thing and get the docs and test coverage done for release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.