Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update glTF 2.0 demo for 'KHR_texture_basisu' #274

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

donmccurdy
Copy link

@donmccurdy donmccurdy commented Dec 24, 2021

The glTF WebGL demo currently has an old reference to "a hypothetical GOOGLE_texture_basis extension", written prior to the availability of the official KHR_texture_basisu extension for glTF. This PR updates the demo, model, and documentation to use the official workflow.

I converted the existing .basis image by:

  1. basisu image.basis
  2. Manually replace the .basis reference with .png reference in .gltf file
  3. Compress with gltf-transform etc1s input.gltf output.gltf

I've also removed broken links to demos – if there's a GitHub pages demo published somewhere we could link to that instead?

@richgel999
Copy link
Contributor

Hmm - appveyor failed. Looks like we're seeing a failure on the formatting rules for this PR - any ideas?

*** The following differences were found between the code and the formatting rules:
diff --git a/webgl/gltf/assets/AgiHqSmall.gltf b/webgl/gltf/assets/AgiHqSmall.gltf
index 5bf4f8c..a2ffa38 100755
--- a/webgl/gltf/assets/AgiHqSmall.gltf
+++ b/webgl/gltf/assets/AgiHqSmall.gltf
@@ -198,4 +198,4 @@
"extensionsRequired": [
"KHR_texture_basisu"
]
-}
\ No newline at end of file
+}
*** Aborting, please fix your commit(s) with 'git commit --amend' or 'git rebase -i '

@richgel999 richgel999 added the enhancement New feature or request label Dec 27, 2021
@donmccurdy
Copy link
Author

donmccurdy commented Dec 28, 2021

Fixed — I added the missing newline at the end of the file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants