th-294: If the server is unavailable, the user is logged out of the system #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rver is not accessible
Some14u
requested review from
kalinkaaaa14,
Druxight and
PavloSukhinin
as code owners
DmytroVoronkov
approved these changes
Sep 21, 2023
…bsa-2023-towhub into fix/th-294-user-unlogging-when-server-is-dead
AlexVlaso
approved these changes
Sep 22, 2023
h0wter
approved these changes
Sep 22, 2023
PavloSukhinin
previously approved these changes
Sep 25, 2023
…bsa-2023-towhub into fix/th-294-user-unlogging-when-server-is-dead
h0wter
approved these changes
Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue
Fixed it, kind of. There is an issue with the logic of this behavior.
When there is no connection with the server, it will be impossible to retrieve the information about user, like name and group.
Therefore, it would be practically impossible to use the application.
I guess, we should discuss what to do in that case.
But as for now, the session stays in the local storage, and after the server is back, it restores.