-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added the type "allrecommandedepisodes" to include unwatched episodes… #44
base: master
Are you sure you want to change the base?
Conversation
… of shows not in progress
library.py
Outdated
@@ -34,7 +34,6 @@ | |||
|
|||
PLOT_ENABLE = True | |||
|
|||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't remove this line (pep8)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That was an oversight of my part while debugging, sorry. It shouldn't be absent indeed
Thx, this is an useful addition. I am only wondering wether we should replace the old recommended episodes with this one. EDIT: |
Well I'm using it locally for about a week now, and I'm happy about it, but I'm not sure it should be default, mainly because the list of episodes in the widget can become a bit long (I went from 14 recommanded eps to 43) so for someone who just wants to keep with their "progress" it could be a problem. But yes, in my case I WANT to also follow the new stuff, and I don't keep old seasons, so for example the old system wouldn't recommand me Walking Dead 701. Also before (maybe) being the default option, it still needs some polishing, which I'm working on :
|
I'm voting for not having this as default. I use the recommended episodes just for keeping up to date with a couple of my shows and don't want it to get unmaintainable huge. |
… of shows not in progress
Typical "recommanded episodes" gives you the first unwatched episode of all the shows that are in progress ; but it's missing two things to help keep up with a big show collection : pilots of new shows, and new seasons when you don't keep the old ones (and as a result have no progress on them on a fresh scan or after a cleanup)
So I added the "allrecommandedepisodes" that extends the normal one