Rc 1 #1851
+17,639
−5,761
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| name: test season pass | ||
|
|
||
| on: | ||
| pull_request: | ||
| paths-ignore: | ||
| - "contracts/**" | ||
| - "client/**" | ||
| - "**/manifest.json" | ||
| - "discord-bot/**" | ||
| - "config/**" | ||
| - ".github/**" | ||
| - "pnpm-lock.yaml" | ||
|
|
||
| env: | ||
| SCARB_VERSION: v2.8.2 | ||
|
|
||
| jobs: | ||
| test-season-pass: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v3 | ||
| - uses: software-mansion/setup-scarb@v1 | ||
| with: | ||
| tool-versions: season_pass/contracts/.tool-versions | ||
| - uses: foundry-rs/setup-snfoundry@v3 | ||
| with: | ||
| tool-versions: season_pass/contracts/.tool-versions | ||
|
Comment on lines
+17
to
+27
There was a problem hiding this comment. 💡 Codebase verification 🛠️ Refactor suggestion Update actions and pin the Ubuntu version. The current workflow uses
🔗 Analysis chainConsider updating actions and pinning the Ubuntu version. The job setup looks good overall, but there are a few suggestions for improvement:
- - uses: actions/checkout@v3
+ - uses: actions/checkout@v4
- runs-on: ubuntu-latest
+ runs-on: ubuntu-22.04
🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Description: Verify the existence and content of the .tool-versions file
# Test: Check if the file exists and display its content
if [ -f "season_pass/contracts/.tool-versions" ]; then
echo "Content of .tool-versions file:"
cat "season_pass/contracts/.tool-versions"
else
echo "Error: .tool-versions file not found"
exit 1
fi
Length of output: 201 Script: #!/bin/bash
# Description: Check the version of actions/checkout in the workflow file
# Use grep to find the actions/checkout version
echo "Checking actions/checkout version:"
grep 'uses: actions/checkout@' .github/workflows/test-season-pass.yml || { echo "actions/checkout not found"; exit 1; }
Length of output: 184 Script: #!/bin/bash
# Description: Verify if the Ubuntu version is pinned in the workflow file
# Check if runs-on is set to ubuntu-latest
echo "Checking runs-on configuration:"
if grep -q 'runs-on: ubuntu-latest' .github/workflows/test-season-pass.yml; then
echo "runs-on is set to ubuntu-latest. Consider pinning to a specific version like ubuntu-22.04."
exit 1
else
echo "runs-on is pinned to a specific Ubuntu version."
fi
Length of output: 346 |
||
| - run: scarb build | ||
| working-directory: season_pass/contracts | ||
| - run: snforge test | ||
| working-directory: season_pass/contracts | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,3 @@ | ||
| node_modules | ||
| target | ||
| .snfoundry_cache |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,2 @@ | ||
| scarb 2.7.0 | ||
| dojo 1.0.0-alpha.17 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,7 @@ | ||
| VITE_PUBLIC_MASTER_ADDRESS="0x127fd5f1fe78a71f8bcd1fec63e3fe2f0486b6ecd5c86a0466c3a21fa5cfcec" | ||
| VITE_PUBLIC_MASTER_PRIVATE_KEY="0xc5b2fcab997346f3ea1c00b002ecf6f382c5f9c9659a3894eb783c5320f912" | ||
| VITE_PUBLIC_WORLD_ADDRESS="0x320b2713e324fe3125bbc42d85ff69cb3c0908b436fa38a35746dbc45deeb11" | ||
| VITE_PUBLIC_ACCOUNT_CLASS_HASH="0x07dc7899aa655b0aae51eadff6d801a58e97dd99cf4666ee59e704249e51adf2" | ||
| VITE_NETWORK_FEE_TOKEN="0x49d36570d4e46f48e99674bd3fcc84644ddd6b96f7c741b1562b82f9e004dc7" | ||
|
Comment on lines
+1
to
+4
There was a problem hiding this comment. 💡 Codebase verification Security Concern Confirmed: The Action Items:
🔗 Analysis chainSecurity concern: Sensitive information in environment file The Consider the following recommendations:
To verify if this file is being tracked by git, run the following command: If the file is tracked, consider adding it to .gitignore to prevent accidental commits of sensitive information. 🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Check if .env.sample is tracked by git
git ls-files --error-unmatch client/.env.sample && echo "File is tracked" || echo "File is not tracked"
Length of output: 109 🧰 Tools🪛 Gitleaks
|
||
| VITE_EVENT_KEY="0x1a2f334228cee715f1f0f54053bb6b5eac54fa336e0bc1aacf7516decb0471d" | ||
| VITE_PUBLIC_TORII="http://localhost:8080" | ||
|
|
@@ -12,5 +12,9 @@ VITE_PUBLIC_DEV=false | |
| VITE_PUBLIC_SHOW_FPS=true | ||
| VITE_PUBLIC_GRAPHICS_DEV=false | ||
|
|
||
| VITE_SEASON_PASS_ADDRESS="0x18cd31a545b13597adeafa40979a7456aae9d12bd0b9a9879089ed051402c6c" | ||
| VITE_REALMS_ADDRESS="0x57e1cb22f5688a833ceff37d8569297877dd8fc1896e36f1a0c8b2d30b7de85" | ||
| VITE_LORDS_ADDRESS="0x5839f41cadbe12678b2e7b67bd6daa5bd54b7b19bdc835c87fe4662dbf7a93c" | ||
|
|
||
| # You will have to change this to your local torii. It will be in the printout. | ||
| VITE_PUBLIC_TORII_RELAY="/ip4/0.0.0.0/udp/9091/webrtc-direct/certhash/uEiAN3-ttwg-yphp9ZgqhSCGNsWLXIo0eHEsrLRUzp4SpKg" | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -22,7 +22,7 @@ export const dojoConfig = createDojoConfig({ | |
| masterAddress: VITE_PUBLIC_MASTER_ADDRESS, | ||
| masterPrivateKey: VITE_PUBLIC_MASTER_PRIVATE_KEY, | ||
| accountClassHash: | ||
| VITE_PUBLIC_ACCOUNT_CLASS_HASH || "0x07dc7899aa655b0aae51eadff6d801a58e97dd99cf4666ee59e704249e51adf2", | ||
|
There was a problem hiding this comment. 💡 Codebase verification Inconsistent
🔗 Analysis chainVerify the new account class hash across the codebase. The To ensure consistency and correctness, please run the following script: Ensure that:
If any inconsistencies are found, please update the relevant files to maintain consistency across the codebase. 🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Description: Verify the new account class hash across the codebase
# Test 1: Check for the new hash in .env files
echo "Checking .env files for the new hash:"
rg "0x07dc7899aa655b0aae51eadff6d801a58e97dd99cf4666ee59e704249e51adf2" .env*
# Test 2: Check for any remaining instances of the old hash
echo "Checking for any remaining instances of the old hash:"
rg "0x05400e90f7e0ae78bd02c77cd75527280470e2fe19c54970dd79dc37a9d3645c"
# Test 3: Verify VITE_PUBLIC_ACCOUNT_CLASS_HASH in .env files
echo "Verifying VITE_PUBLIC_ACCOUNT_CLASS_HASH in .env files:"
rg "VITE_PUBLIC_ACCOUNT_CLASS_HASH" .env*
Length of output: 610 Script: #!/bin/bash
# Description: Comprehensive verification of the account class hash across the entire codebase
# Test 1: Check for the new hash in all files
echo "Checking for the new account class hash in the codebase:"
rg "0x07dc7899aa655b0aae51eadff6d801a58e97dd99cf4666ee59e704249e51adf2" --hidden --ignore-dir={node_modules,dist,build}
# Test 2: Check for any remaining instances of the old hash in all files
echo "Checking for any remaining instances of the old account class hash in the codebase:"
rg "0x05400e90f7e0ae78bd02c77cd75527280470e2fe19c54970dd79dc37a9d3645c" --hidden --ignore-dir={node_modules,dist,build}
# Test 3: Verify all instances of VITE_PUBLIC_ACCOUNT_CLASS_HASH are updated
echo "Verifying all occurrences of VITE_PUBLIC_ACCOUNT_CLASS_HASH in the codebase:"
rg "VITE_PUBLIC_ACCOUNT_CLASS_HASH" --hidden --ignore-dir={node_modules,dist,build}
Length of output: 2187 Script: #!/bin/bash
# Description: Comprehensive verification of the account class hash across the entire codebase with corrected rg commands
# Test 1: Check for the new hash in all files
echo "Checking for the new account class hash in the codebase:"
rg "0x07dc7899aa655b0aae51eadff6d801a58e97dd99cf4666ee59e704249e51adf2" --hidden --ignore-dir node_modules --ignore-dir dist --ignore-dir build
# Test 2: Check for any remaining instances of the old account class hash in all files
echo "Checking for any remaining instances of the old account class hash in the codebase:"
rg "0x05400e90f7e0ae78bd02c77cd75527280470e2fe19c54970dd79dc37a9d3645c" --hidden --ignore-dir node_modules --ignore-dir dist --ignore-dir build
# Test 3: Verify all instances of VITE_PUBLIC_ACCOUNT_CLASS_HASH are updated
echo "Verifying all occurrences of VITE_PUBLIC_ACCOUNT_CLASS_HASH in the codebase:"
rg "VITE_PUBLIC_ACCOUNT_CLASS_HASH" --hidden --ignore-dir node_modules --ignore-dir dist --ignore-dir build
Length of output: 2187 Script: #!/bin/bash
# Description: Comprehensive verification of the account class hash across the entire codebase using --glob to exclude directories
# Test 1: Check for the new account class hash in all files except excluded directories
echo "Checking for the new account class hash in the codebase:"
rg "0x07dc7899aa655b0aae51eadff6d801a58e97dd99cf4666ee59e704249e51adf2" --hidden --glob '!node_modules/**' --glob '!dist/**' --glob '!build/**'
# Test 2: Check for any remaining instances of the old account class hash in all files except excluded directories
echo "Checking for any remaining instances of the old account class hash in the codebase:"
rg "0x05400e90f7e0ae78bd02c77cd75527280470e2fe19c54970dd79dc37a9d3645c" --hidden --glob '!node_modules/**' --glob '!dist/**' --glob '!build/**'
# Test 3: Verify all instances of VITE_PUBLIC_ACCOUNT_CLASS_HASH are updated in all files except excluded directories
echo "Verifying all occurrences of VITE_PUBLIC_ACCOUNT_CLASS_HASH in the codebase:"
rg "VITE_PUBLIC_ACCOUNT_CLASS_HASH" --hidden --glob '!node_modules/**' --glob '!dist/**' --glob '!build/**'
Length of output: 2251 |
||
| feeTokenAddress: VITE_PUBLIC_FEE_TOKEN_ADDRESS || "0x49d36570d4e46f48e99674bd3fcc84644ddd6b96f7c741b1562b82f9e004dc7", | ||
| manifest, | ||
| }); | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -13,17 +13,17 @@ | |
| "coverage": "vitest run --coverage" | ||
| }, | ||
| "peerDependencies": { | ||
| "starknet": "6.11.0" | ||
| }, | ||
| "dependencies": { | ||
| "@bibliothecadao/eternum": "workspace:^", | ||
| "@dojoengine/core": "1.0.0-alpha.22", | ||
| "@dojoengine/create-burner": "1.0.0-alpha.22", | ||
| "@dojoengine/react": "1.0.0-alpha.22", | ||
| "@dojoengine/recs": "^2.0.13", | ||
| "@dojoengine/state": "1.0.0-alpha.22", | ||
| "@dojoengine/torii-client": "1.0.0-alpha.22", | ||
| "@dojoengine/utils": "1.0.0-alpha.22", | ||
| "@headlessui/react": "^1.7.18", | ||
| "@latticexyz/utils": "^2.0.0-next.12", | ||
| "@radix-ui/react-select": "^2.0.0", | ||
|
|
||
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Consider using the SCARB_VERSION environment variable.
The
SCARB_VERSIONenvironment variable is defined but not explicitly used in the workflow steps. To ensure consistency and make version updates easier, consider using this variable in the setup steps.Update the Scarb setup step to use the environment variable:
- uses: software-mansion/setup-scarb@v1 with: + scarb-version: ${{ env.SCARB_VERSION }} tool-versions: season_pass/contracts/.tool-versions📝 Committable suggestion