Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Platform: Comment button does not appear on text with a superscript #128

Closed
Sebastian-ubs opened this issue Jul 3, 2024 · 1 comment · Fixed by paranext/paranext-core#1068
Closed

Platform: Comment button does not appear on text with a superscript #128

Sebastian-ubs opened this issue Jul 3, 2024 · 1 comment · Fixed by paranext/paranext-core#1068
Assignees
@irahopkinson
Labels
bug Something isn't working

Comments

@Sebastian-ubs
Copy link

Double clicking a word with a superscript does not bring up the comment button
grafik
@Sebastian-ubs Sebastian-ubs added the bug Something isn't working label Jul 3, 2024
@irahopkinson
Copy link
Contributor

@Sebastian-ubs thanks for finding that. Yes you can't comment on a footnote/xref which is currently included in your selection. A work-around for now is to manually select the word (rather than use double-click). I'll need to figure out how to fix the double-click selection to not include the footnote/xref.

@irahopkinson irahopkinson self-assigned this Aug 13, 2024
irahopkinson added a commit that referenced this issue Aug 14, 2024
@irahopkinson
Fix #128 double-click selection
8b4ea4f 
- add ZWSP after verse number so double-clicking first word after the number only selects that word
- add ZWSP as list child of NoteNode so double-clicking first word after the note only selects that word
- also remove undefined properties from `serializedEditorState` to improve debugging
irahopkinson added a commit that referenced this issue Aug 14, 2024
@irahopkinson
Fix #128 double-click selection
24f4657 
- add ZWSP after verse number so double-clicking first word after the number only selects that word
- add ZWSP as list child of NoteNode so double-clicking first word after the note only selects that word
- also remove undefined properties from `serializedEditorState` to improve debugging
irahopkinson added a commit that referenced this issue Aug 14, 2024
@irahopkinson
Fix #128 double-click selection
66aedb5 
- add ZWSP after verse number so double-clicking first word after the number only selects that word
- add ZWSP as list child of NoteNode so double-clicking first word after the note only selects that word
- also remove undefined properties from `serializedEditorState` to improve debugging
irahopkinson added a commit to paranext/paranext-core that referenced this issue Aug 14, 2024
@irahopkinson
update editor
8c62e45 
- fixes #1007 ignore backslash keypress and if contained in paste or drag
- fixes BiblioNexus-Foundation/scripture-editors#128 double-click selection ignores verse numbers and <notes>
- fixes BiblioNexus-Foundation/scripture-editors#126 improve toolbar block width
@irahopkinson irahopkinson mentioned this issue Aug 14, 2024
Merged
irahopkinson added a commit to paranext/paranext-core that referenced this issue Aug 14, 2024
@irahopkinson
update editor (#1068)
fcaa770 
- fixes #1007 ignore backslash keypress and if contained in paste or drag
- fixes BiblioNexus-Foundation/scripture-editors#128 double-click selection ignores verse numbers and `<notes>`
- fixes BiblioNexus-Foundation/scripture-editors#126 improve toolbar block width
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@irahopkinson irahopkinson

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

update editor paranext/paranext-core
2 participants
@irahopkinson @Sebastian-ubs