OR conditions are implemented as AND

[fruel]

(I think this is the issue @davidnmbond mentioned in #8 )

In SieveModel.cs where the filter expression is parsed only more AND-conditions are added to the list of filter items.

I think the issue happened because of a typo in the unit test here. I assume the value for Title should be "D" not "3" - then the test fails as expected.

[Biarity]

Yup, just realised this doesn't actually do any OR logic. I'll be rewriting the parser in a proper framework ASAP. Sorry about that!

[davidnmbond]

Confirmed - the unit test is wrong - changing the term was stated means that unit tests (correctly) fail.
Looking into a fix now...

[Biarity]

Published to nuget as 2.1.0. Thanks for your efforts!

[davidnmbond]

No problem - I'm looking forward to seeing/helping Sieve develop further. If you need a hand, please add me as a contributor.

[Biarity]

That would be great! Looking at open issues - I was going to rewrite the parser next in something like Sparche to add flexibility and allow escape sequences, arbitrary logic, & data shaping. Of course that necessitates a more flexible way of converting the query to LINQ, meaning part of SieveProcessor.ApplyFiltering would also need to be rewritten.

[AlexandreBonfim]

Yup, just realised this doesn't actually do any OR logic. I'll be rewriting the parser in a proper framework ASAP. Sorry about that!

@Biarity How can I use OR logic? For example filters=Name@=*test,location@=*malta ...

Thanks, your library save a lot of time! :)

[Biarity]

I'll be working on this later but unfortunately am quite busy at the moment.