Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix input syntax #6

Merged
merged 2 commits into from
Oct 5, 2023
Merged

Fix input syntax #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5a52af2
Fix input syntax
beuluis Oct 5, 2023
fac7dcc
Fix input syntax
beuluis Oct 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 4 additions & 10 deletions .github/workflows/environment-setup.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,18 +4,12 @@
inputs:
package_manager:
default: npm
description: Package manager to use
options:
- npm
- bun
type: choice
description: Package manager to use. Can be 'npm' or 'bun'
type: string
dependencies_type:
default: prod
description: Dependencies type to install
options:
- prod
- dev
type: choice
description: Dependencies type to install. Can be 'prod' or 'dev'
type: string
node_version:
description: Node version to setup
default: "18"
Expand Down
7 changes: 2 additions & 5 deletions .github/workflows/github-npm-publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,8 @@
type: string
package_manager:
default: npm
description: Package manager to use
options:
- npm
- bun
type: choice
description: Package manager to use. Can be 'npm' or 'bun'
type: string

jobs:
publish:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/internal-linting.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,4 +23,4 @@ jobs:
with:
go-version: stable
- run: go install github.com/rhysd/actionlint/cmd/actionlint@latest
- run: actionlint --ignore "^unexpected key \"options\" for \"inputs at workflow_call event\" section\. expected one of .*" --ignore "^invalid value \"choice\" for input type of workflow_call event. it must be one of .*"
- run: actionlint
7 changes: 2 additions & 5 deletions .github/workflows/npm-node-qa-testing.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,8 @@
type: string
package_manager:
default: npm
description: Package manager to use
options:
- npm
- bun
type: choice
description: Package manager to use. Can be 'npm' or 'bun'
type: string
format_command:
description: Format command to run. Disabled by default
default:
Expand Down
7 changes: 2 additions & 5 deletions .github/workflows/npm-publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,8 @@
type: string
package_manager:
default: npm
description: Package manager to use
options:
- npm
- bun
type: choice
description: Package manager to use. Can be 'npm' or 'bun'
type: string
secrets:
NPM_TOKEN:
description: NPM token with right access for publishing
Expand Down
34 changes: 17 additions & 17 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,11 +39,11 @@ Publish a NPM package to the NPM registry.

#### Inputs

| Name | Description | Type | Default | Required |
| ----------------- | --------------------------- | -------- | -------- | -------- |
| `dist_tag` | NPM dist tag to publish to. | `string` | `latest` | `false` |
| `node_version` | Node version to build on. | `string` | `18` | `false` |
| `package_manager` | Package manager to use. | `choice` | `npm` | `false` |
| Name | Description | Type | Default | Required |
| ----------------- | ---------------------------------------------- | -------- | -------- | -------- |
| `dist_tag` | NPM dist tag to publish to. | `string` | `latest` | `false` |
| `node_version` | Node version to build on. | `string` | `18` | `false` |
| `package_manager` | Package manager to use. Can be 'npm' or 'bun'. | `string` | `npm` | `false` |

#### Secrets

Expand All @@ -61,11 +61,11 @@ Publish a NPM package to the GitHub registry.

#### Inputs

| Name | Description | Type | Default | Required |
| ----------------- | --------------------------- | -------- | ------- | -------- |
| `dist_tag` | NPM dist tag to publish to. | `string` | `` | `true` |
| `node_version` | Node version to build on. | `string` | `18` | `false` |
| `package_manager` | Package manager to use. | `choice` | `npm` | `false` |
| Name | Description | Type | Default | Required |
| ----------------- | ---------------------------------------------- | -------- | ------- | -------- |
| `dist_tag` | NPM dist tag to publish to. | `string` | `` | `true` |
| `node_version` | Node version to build on. | `string` | `18` | `false` |
| `package_manager` | Package manager to use. Can be 'npm' or 'bun'. | `string` | `npm` | `false` |

#### Secrets

Expand Down Expand Up @@ -121,7 +121,7 @@ Testing for node app using npm as package manager, libraries and components.
| Name | Description | Type | Default | Required |
| ---------------------- | ------------------------------------------------------------------- | --------- | -------------------------- | -------- |
| `node_versions` | Node versions matrix to test on. | `string` | `['16.x', '17.x', '18.x']` | `false` |
| `package_manager` | Package manager to use. | `choice` | `npm` | `false` |
| `package_manager` | Package manager to use. Can be 'npm' or 'bun'. | `string` | `npm` | `false` |
| `format_command` | Format command to run. To disable set to `''`. | `string` | `npm run format` | `false` |
| `lint_command` | Lint command to run. To disable set to `''`. | `string` | `npm run lint` | `false` |
| `build_command` | Build command to run. | `string` | `npm run build` | `false` |
Expand Down Expand Up @@ -165,12 +165,12 @@ Checks out the commit, set up the node env and setup the package manager with ca

#### Inputs

| Name | Description | Type | Default | Required |
| ------------------- | -------------------------------- | -------- | ---------------------------- | -------- |
| `node_versions` | Node versions matrix to test on. | `string` | `['16.x', '17.x', '18.x']` | `false` |
| `package_manager` | Package manager to use. | `choice` | `npm` | `false` |
| `dependencies_type` | Dependencies type to install. | `choice` | `prod` | `false` |
| `registry_url` | Registry url to use. | `string` | `https://registry.npmjs.org` | `false` |
| Name | Description | Type | Default | Required |
| ------------------- | ---------------------------------------------------- | -------- | ---------------------------- | -------- |
| `node_versions` | Node versions matrix to test on. | `string` | `['16.x', '17.x', '18.x']` | `false` |
| `package_manager` | Package manager to use. Can be 'npm' or 'bun'. | `string` | `npm` | `false` |
| `dependencies_type` | Dependencies type to install. Can be 'prod' or 'dev' | `string` | `prod` | `false` |
| `registry_url` | Registry url to use. | `string` | `https://registry.npmjs.org` | `false` |

## Directory structure and file naming

Expand Down
2 changes: 1 addition & 1 deletion makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
lint:
@echo "Lint all yaml files in repository"
yamllint . -s
actionlint --ignore "^unexpected key \"options\" for \"inputs at workflow_call event\" section\. expected one of .*" --ignore "^invalid value \"choice\" for input type of workflow_call event. it must be one of .*"
actionlint