drop ruby <3.0 and rails <6.1 support #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cop fixes (rubocop -f o): 22 Style/FrozenStringLiteralComment 2 Style/HashSyntax 1 Lint/RedundantRequireStatement 1 Style/RedundantFreeze
effron
reviewed
Jan 2, 2024
argvniyx-enroute
changed the title
effron
requested changes
Jan 2, 2024
.gitignore
Outdated
| @@ -7,5 +7,4 @@ spec/dummy/db/*.sqlite3 | |||
| spec/dummy/config/deprecations.ignore | |||
| doc/ | |||
| .yardoc/ | |||
| Gemfile.lock | |||
| /gemfiles/*.gemfile.lock | |||
There was a problem hiding this comment.
let's remove this as well, since CI runs against the various appraisal gemfiles (and commit the gemfile.lock for each appraisal)
There was a problem hiding this comment.
Ok, did this. I unpinned appraisal (see: thoughtbot/appraisal#199 (comment); tldr be appraisal install didn't work with the version we had)
Co-authored-by: Harris Effron <[email protected]>
Co-authored-by: Harris Effron <[email protected]>
unpinned `appraisal` because of an issue with ruby 3.2 + bundler 2.4<=; see thoughtbot/appraisal#199 (comment) unpinning gives us `appraisal 2.5.0`, version by which we have a fix (we want to run `be appraisal install`) to generate lockfiles
gemfiles are updated since we unpinned `appraisal`
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/task https://app.asana.com/0/1206095065335149/1206255023426969/f
Summary of changes:
Appraisalsentries and filesTargetRubyVersionand runrubocop -A.ruby-versionGemfile.lockI bumped the minor version (as opposed to patch) since I saw that was what was done for similar things in the past (v. 0.3.0 in the changelog)
@smudge @effron
Cop fixes (rubocop -f o):
22 Style/FrozenStringLiteralComment
2 Style/HashSyntax(reverted since we're leaving this on Ruby 3.0.6)1 Lint/RedundantRequireStatement
1 Style/RedundantFreeze